From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [PATCH 4/5] add isolate pages vmstat
Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang <fengguang.wu@intel.com>,
       LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Christoph Lameter <cl@linux-foundation.org>,
       David Rientjes <rientjes@google.com>, Rik van Riel <riel@redhat.com>
In-Reply-To: <28c262360907050751t1fccbf4t4ace572b4e003a13@mail.gmail.com>
References: <20090705211127.0917.A69D9226@jp.fujitsu.com> <28c262360907050751t1fccbf4t4ace572b4e003a13@mail.gmail.com>
Message-Id: <20090706182750.0C54.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Mon,  6 Jul 2009 18:28:01 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 889
Lines: 29

> > ? ? ? ?printk("Active_anon:%lu active_file:%lu inactive_anon:%lu\n"
> > - ? ? ? ? ? ? ? " inactive_file:%lu"
> > - ? ? ? ? ? ? ? " unevictable:%lu"
> > + ? ? ? ? ? ? ? " inactive_file:%lu unevictable:%lu isolated:%lu\n"
> 
> It's good.
> I have a one suggestion.
> 
> I know this patch came from David's OOM problem a few days ago.
> 
> I think total pages isolated of all lru doesn't help us much.
> It just represents why [in]active[anon/file] is zero.
> 
> How about adding isolate page number per each lru ?
> 
> IsolatedPages(file)
> IsolatedPages(anon)
> 
> It can help knowing exact number of each lru.

Good suggestion!
Will fix.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/