Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbZGFPz5 (ORCPT ); Mon, 6 Jul 2009 11:55:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751049AbZGFPzt (ORCPT ); Mon, 6 Jul 2009 11:55:49 -0400 Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:63995 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbZGFPzs (ORCPT ); Mon, 6 Jul 2009 11:55:48 -0400 Date: Mon, 6 Jul 2009 11:55:40 -0400 (EDT) From: Tim Abbott X-X-Sender: tabbott@vinegar-pot.mit.edu To: Jan Beulich cc: Rusty Russell , tony.luck@intel.com, Benjamin Herrenschmidt , Tim Abbott , sam@ravnborg.org, Paul Mackerras , linux-kernel@vger.kernel.org Subject: Re: [PATCH] also discard .*init sections after module initialization In-Reply-To: <4A4B2683020000780000862F@vpn.id2.novell.com> Message-ID: References: <4A4A19C60200007800008353@vpn.id2.novell.com> <200907011452.26720.rusty@rustcorp.com.au> <4A4B2683020000780000862F@vpn.id2.novell.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Flag: NO X-Spam-Score: 0.00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1979 Lines: 46 On Wed, 1 Jul 2009, Jan Beulich wrote: > >>> Rusty Russell 01.07.09 07:22 >>> > >On Tue, 30 Jun 2009 09:27:26 pm Jan Beulich wrote: > >> Just like .init, these sections are supposed to be unneeded after init, > >> and modpost warns about improper section references anyway. > > > >Tim Abbot had a section renaming patch, for -ffunction-sections. Can we kill > >two birds with one stone and have a unique string for init sections, and > >another for exit sections? > > Not sure, would need to see what that patch does first. And then, the patch > here doesn't do any renaming. We don't need to rename the .{dev,cpu,mem}init.* sections for -ffunction-sections -fdata-sections; the only things that need to be renamed for that are sections with names that start with ".text.", ".data.", ".bss.", and ".rodata." since those are the section names generated by -ffunction-sections -fdata-sections. So I think that this change is orthogonal to my efforts. > >> Likewise > >> for .*exit which, other than .exit, aren't needed for the module unload > >> path. > > > >Currently true, but I can't see that being true in general. > > Why? .*exit sections deal with device/memory/CPU hot remove, which is > orthogonal to module unload. For the core kernel, the .devinit sections are currently being squashed into either the .data section or the .init.data section depending on whether hotplug is enabled using the vmlinux linker scripts. Can we use the same approach for modules (i.e. have a module linker script that does this)? It seems that would avoid having two duplicate mechanisms for doing the same thing, one in the module loader and one in the core kernel's linker scripts. -Tim Abbott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/