Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbZGFRUV (ORCPT ); Mon, 6 Jul 2009 13:20:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751490AbZGFRUK (ORCPT ); Mon, 6 Jul 2009 13:20:10 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:45085 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbZGFRUJ (ORCPT ); Mon, 6 Jul 2009 13:20:09 -0400 Message-ID: <4A523135.40408@cs.helsinki.fi> Date: Mon, 06 Jul 2009 20:15:33 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605) MIME-Version: 1.0 To: Johannes Berg CC: Vegard Nossum , linux-kernel Subject: Re: [PATCH] kmemcheck: fix sparse warning References: <1246873983.20908.0.camel@johannes.local> In-Reply-To: <1246873983.20908.0.camel@johannes.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1357 Lines: 44 Johannes Berg wrote: > Whether or not the sparse warning > > warning: do-while statement is not a compound statement > > is justified or not in this case, it is annoying and > trivial to fix. > > Signed-off-by: Johannes Berg Looks good to me! Acked-by: Pekka Enberg > --- > include/linux/kmemcheck.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- wireless-testing.orig/include/linux/kmemcheck.h 2009-07-06 11:41:16.000000000 +0200 > +++ wireless-testing/include/linux/kmemcheck.h 2009-07-06 11:41:30.000000000 +0200 > @@ -137,13 +137,13 @@ static inline void kmemcheck_mark_initia > int name##_end[0]; > > #define kmemcheck_annotate_bitfield(ptr, name) \ > - do if (ptr) { \ > + do { if (ptr) { \ > int _n = (long) &((ptr)->name##_end) \ > - (long) &((ptr)->name##_begin); \ > BUILD_BUG_ON(_n < 0); \ > \ > kmemcheck_mark_initialized(&((ptr)->name##_begin), _n); \ > - } while (0) > + } } while (0) > > #define kmemcheck_annotate_variable(var) \ > do { \ > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/