Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbZGFRX7 (ORCPT ); Mon, 6 Jul 2009 13:23:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753847AbZGFRXn (ORCPT ); Mon, 6 Jul 2009 13:23:43 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:56776 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753783AbZGFRXm (ORCPT ); Mon, 6 Jul 2009 13:23:42 -0400 Date: Mon, 6 Jul 2009 13:23:45 -0400 From: Christoph Hellwig To: Nick Piggin Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara , LKML , linux-mm@kvack.org Subject: Re: [rfc][patch 2/3] fs: make use of new helper functions Message-ID: <20090706172345.GB26042@infradead.org> References: <20090706165438.GQ2714@wotan.suse.de> <20090706165522.GR2714@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090706165522.GR2714@wotan.suse.de> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 23 On Mon, Jul 06, 2009 at 06:55:22PM +0200, Nick Piggin wrote: > > Update some fs code to make use of new helper functions introduced > in the previous patch. Should be no significant change in behaviour > (except CIFS now calls send_sig under i_lock, via inode_truncate_ok). > > --- > fs/buffer.c | 10 +-------- > fs/cifs/inode.c | 51 ++++++++----------------------------------------- > fs/fuse/dir.c | 13 +++--------- > fs/fuse/fuse_i.h | 2 - > fs/fuse/inode.c | 10 --------- > fs/nfs/inode.c | 52 +++++++++++--------------------------------------- > fs/ramfs/file-nommu.c | 18 ++++------------- > 7 files changed, 33 insertions(+), 123 deletions(-) Nice cleanup. I would recommend moving the introduction of those helpers to this patch and make it the first in the series. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/