Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbZGFRro (ORCPT ); Mon, 6 Jul 2009 13:47:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751964AbZGFRrg (ORCPT ); Mon, 6 Jul 2009 13:47:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47204 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbZGFRrf (ORCPT ); Mon, 6 Jul 2009 13:47:35 -0400 Date: Mon, 6 Jul 2009 19:47:38 +0200 From: Nick Piggin To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, Jan Kara , LKML , linux-mm@kvack.org Subject: Re: [rfc][patch 2/3] fs: make use of new helper functions Message-ID: <20090706174738.GU2714@wotan.suse.de> References: <20090706165438.GQ2714@wotan.suse.de> <20090706165522.GR2714@wotan.suse.de> <20090706172345.GB26042@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090706172345.GB26042@infradead.org> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 27 On Mon, Jul 06, 2009 at 01:23:45PM -0400, Christoph Hellwig wrote: > On Mon, Jul 06, 2009 at 06:55:22PM +0200, Nick Piggin wrote: > > > > Update some fs code to make use of new helper functions introduced > > in the previous patch. Should be no significant change in behaviour > > (except CIFS now calls send_sig under i_lock, via inode_truncate_ok). > > > > --- > > fs/buffer.c | 10 +-------- > > fs/cifs/inode.c | 51 ++++++++----------------------------------------- > > fs/fuse/dir.c | 13 +++--------- > > fs/fuse/fuse_i.h | 2 - > > fs/fuse/inode.c | 10 --------- > > fs/nfs/inode.c | 52 +++++++++++--------------------------------------- > > fs/ramfs/file-nommu.c | 18 ++++------------- > > 7 files changed, 33 insertions(+), 123 deletions(-) > > Nice cleanup. I would recommend moving the introduction of those > helpers to this patch and make it the first in the series. OK I will do that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/