Date: Mon, 6 Jul 2009 21:11:51 +0200 (CEST)
From: Marton Balint <cus@fazekas.hu>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
cc: linux-kernel@vger.kernel.org
Subject: Re: vfat creates multiple files with the same filename
In-Reply-To: <87y6r9dz4h.fsf@devron.myhome.or.jp>
Message-ID: <Pine.LNX.4.64.0907062105470.31518@cinke.fazekas.hu>
References: <Pine.LNX.4.64.0906281935490.20945@cinke.fazekas.hu>
 <87tz1ylaq8.fsf@devron.myhome.or.jp> <Pine.LNX.4.64.0907010158560.835@cinke.fazekas.hu>
 <87y6r9dz4h.fsf@devron.myhome.or.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1372
Lines: 37

On Wed, 1 Jul 2009, OGAWA Hirofumi wrote:

> Marton Balint <cus@fazekas.hu> writes:
> 
> > On Tue, 30 Jun 2009, OGAWA Hirofumi wrote:
> >> Marton Balint <cus@fazekas.hu> writes:
> >> 
> >> > I don't know if removing the invalid characters silently instead of 
> >> > returning EINVAL is a good practice, but allowing two files with identical 
> >> > filenames is definitely wrong. 
> >> 
> >> The utf8 function seems didn't return the error for invalid char.
> >> 
> >> > Could someone please have a look at the problem? Unfortunately I am not 
> >> > qualified enough to track it down...
> >> >
> >> > I've run the testcase on both 2.6.30 and 2.6.31-rc1 kernels, but this bug 
> >> > is probably not very new, since I remember having it also in 2.6.27.
> >> 
> >> This is quick hack though, this should return -EINVAL for invalid char
> >> like nls.  Can you try this?
> >
> > It works for me, filenames with invalid utf-8 characters are now rejected, 
> > so I no longer can create multiple files with the same name. Thanks for 
> > the fix.
> 
> Thanks for testing.

Will the patch be included in 2.6.31?

Regards,
  Marton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/