Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277AbZGFVcj (ORCPT ); Mon, 6 Jul 2009 17:32:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753263AbZGFVcb (ORCPT ); Mon, 6 Jul 2009 17:32:31 -0400 Received: from terminus.zytor.com ([198.137.202.10]:37196 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940AbZGFVcb (ORCPT ); Mon, 6 Jul 2009 17:32:31 -0400 Message-ID: <4A526D38.7000803@zytor.com> Date: Mon, 06 Jul 2009 14:31:36 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Borislav Petkov CC: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [x86, msr]: remove code duplication References: <1246890592-12256-1-git-send-email-borislav.petkov@amd.com> In-Reply-To: <1246890592-12256-1-git-send-email-borislav.petkov@amd.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 16 Borislav Petkov wrote: > - > - smp_call_function_many(mask, __rdmsr_on_cpu, &rv, 1); > + smp_call_function_single(this_cpu, msr_func, &rv, 1); > + smp_call_function_many(mask, msr_func, &rv, 1); > preempt_enable(); Why are you using smp_call_function_single() to execute something *on your own CPU*? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/