Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757554AbZGGAJr (ORCPT ); Mon, 6 Jul 2009 20:09:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756822AbZGGAHx (ORCPT ); Mon, 6 Jul 2009 20:07:53 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:39081 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757074AbZGGAHv (ORCPT ); Mon, 6 Jul 2009 20:07:51 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Minchan Kim Subject: Re: [PATCH 4/5] add isolate pages vmstat Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang , LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel In-Reply-To: <20090707090120.1e71a060.minchan.kim@barrios-desktop> References: <20090706204412.0C5D.A69D9226@jp.fujitsu.com> <20090707090120.1e71a060.minchan.kim@barrios-desktop> Message-Id: <20090707090509.0C60.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Tue, 7 Jul 2009 09:07:50 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5063 Lines: 134 > > > ============ CUT HERE =============== > > Subject: [PATCH] add isolate pages vmstat > > > > If the system have plenty threads or processes, concurrent reclaim can > > isolate very much pages. > > Unfortunately, current /proc/meminfo and OOM log can't show it. > > > > This patch provide the way of showing this information. > > > > > > reproduce way > > ----------------------- > > % ./hackbench 140 process 1000 > > => couse OOM > > > > Active_anon:146 active_file:41 inactive_anon:0 > > inactive_file:0 unevictable:0 > > isolated_anon:49245 isolated_file:113 > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > dirty:0 writeback:0 buffer:49 unstable:0 > > free:184 slab_reclaimable:276 slab_unreclaimable:5492 > > mapped:87 pagetables:28239 bounce:0 > > > > > > Signed-off-by: KOSAKI Motohiro > > --- > > drivers/base/node.c | 4 ++++ > > fs/proc/meminfo.c | 4 ++++ > > include/linux/mmzone.h | 2 ++ > > mm/page_alloc.c | 10 ++++++++-- > > mm/vmscan.c | 5 +++++ > > mm/vmstat.c | 3 ++- > > 6 files changed, 25 insertions(+), 3 deletions(-) > > > > Index: b/fs/proc/meminfo.c > > =================================================================== > > --- a/fs/proc/meminfo.c > > +++ b/fs/proc/meminfo.c > > @@ -65,6 +65,8 @@ static int meminfo_proc_show(struct seq_ > > "Active(file): %8lu kB\n" > > "Inactive(file): %8lu kB\n" > > "Unevictable: %8lu kB\n" > > + "Isolated(anon): %8lu kB\n" > > + "Isolated(file): %8lu kB\n" > > "Mlocked: %8lu kB\n" > > #ifdef CONFIG_HIGHMEM > > "HighTotal: %8lu kB\n" > > @@ -109,6 +111,8 @@ static int meminfo_proc_show(struct seq_ > > K(pages[LRU_ACTIVE_FILE]), > > K(pages[LRU_INACTIVE_FILE]), > > K(pages[LRU_UNEVICTABLE]), > > + K(global_page_state(NR_ISOLATED_ANON)), > > + K(global_page_state(NR_ISOLATED_FILE)), > > K(global_page_state(NR_MLOCK)), > > #ifdef CONFIG_HIGHMEM > > K(i.totalhigh), > > Index: b/include/linux/mmzone.h > > =================================================================== > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -100,6 +100,8 @@ enum zone_stat_item { > > NR_BOUNCE, > > NR_VMSCAN_WRITE, > > NR_WRITEBACK_TEMP, /* Writeback using temporary buffers */ > > + NR_ISOLATED_ANON, /* Temporary isolated pages from anon lru */ > > + NR_ISOLATED_FILE, /* Temporary isolated pages from file lru */ > > #ifdef CONFIG_NUMA > > NUMA_HIT, /* allocated in intended node */ > > NUMA_MISS, /* allocated in non intended node */ > > Index: b/mm/page_alloc.c > > =================================================================== > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -2116,8 +2116,8 @@ void show_free_areas(void) > > } > > > > printk("Active_anon:%lu active_file:%lu inactive_anon:%lu\n" > > - " inactive_file:%lu" > > - " unevictable:%lu" > > + " inactive_file:%lu unevictable:%lu\n" > > + " isolated_anon:%lu isolated_file:%lu\n" > > " dirty:%lu writeback:%lu buffer:%lu unstable:%lu\n" > > " free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n" > > " mapped:%lu pagetables:%lu bounce:%lu\n", > > @@ -2126,6 +2126,8 @@ void show_free_areas(void) > > global_page_state(NR_INACTIVE_ANON), > > global_page_state(NR_INACTIVE_FILE), > > global_page_state(NR_UNEVICTABLE), > > + global_page_state(NR_ISOLATED_ANON), > > + global_page_state(NR_ISOLATED_FILE), > > global_page_state(NR_FILE_DIRTY), > > global_page_state(NR_WRITEBACK), > > nr_blockdev_pages(), > > @@ -2151,6 +2153,8 @@ void show_free_areas(void) > > " active_file:%lukB" > > " inactive_file:%lukB" > > " unevictable:%lukB" > > + " isolated(anon):%lukB" > > + " isolated(file):%lukB" > > " present:%lukB" > > " mlocked:%lukB" > > " dirty:%lukB" > > @@ -2176,6 +2180,8 @@ void show_free_areas(void) > > K(zone_page_state(zone, NR_ACTIVE_FILE)), > > K(zone_page_state(zone, NR_INACTIVE_FILE)), > > K(zone_page_state(zone, NR_UNEVICTABLE)), > > + K(zone_page_state(zone, NR_ISOLATED_ANON)), > > + K(zone_page_state(zone, NR_ISOLATED_FILE)), > > K(zone->present_pages), > > K(zone_page_state(zone, NR_MLOCK)), > > K(zone_page_state(zone, NR_FILE_DIRTY)), > > Index: b/mm/vmscan.c > > =================================================================== > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -1082,6 +1082,7 @@ static unsigned long shrink_inactive_lis > > -count[LRU_ACTIVE_ANON]); > > __mod_zone_page_state(zone, NR_INACTIVE_ANON, > > -count[LRU_INACTIVE_ANON]); > > + __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, nr_taken); > > Lumpy can reclaim file + anon anywhere. > How about using count[NR_LRU_LISTS]? Ah yes, good catch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/