Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755181AbZGGJaQ (ORCPT ); Tue, 7 Jul 2009 05:30:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753633AbZGGJaF (ORCPT ); Tue, 7 Jul 2009 05:30:05 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:61193 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752076AbZGGJaE (ORCPT ); Tue, 7 Jul 2009 05:30:04 -0400 Message-ID: <4A5315A4.9080405@cn.fujitsu.com> Date: Tue, 07 Jul 2009 17:30:12 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Thomas Gleixner CC: Ingo Molnar , Steven Rostedt , Frederic Weisbecker , Mathieu Desnoyers , Zhaolei , kosaki.motohiro@jp.fujitsu.com, LKML Subject: Re: [PATCH v2 3/3] ftrace: add tracepoint for itimer References: <4A51C5C2.20802@cn.fujitsu.com> <4A51C6F9.3080100@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 39 Hi Thomas, Thanks for your review. Thomas Gleixner wrote: > On Mon, 6 Jul 2009, Xiao Guangrong wrote: >> +TRACE_EVENT(itimer_state, >> + >> + TP_PROTO(int which, struct itimerval *value, cputime_t expires), >> + >> + TP_ARGS(which, value, expires), >> + >> + TP_STRUCT__entry( >> + __field( int, which ) >> + __field( void *, timer ) >> + __field( int, state ) >> + __field( cputime_t, expires ) >> + __field( long, value_sec ) >> + __field( long, value_usec ) >> + __field( long, interval_sec ) >> + __field( long, interval_usec ) >> + __string( comm, current->comm ) >> + ), >> + >> + TP_fast_assign( >> + __entry->which = which; >> + __entry->timer = which == ITIMER_REAL ? >> + ¤t->signal->real_timer : NULL; > > Why do we need this information at all ? There is no value in the > address of real_timer AFAICT. > Thanks for your review. I'll send a new patch with your comments addressed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/