Date: 07 Jul 2009 13:21:11 +0200
From: krzysztof.h1@poczta.fm
Subject: Please revert 4148df9b0f38bdd362dd91d52076926c11cbe5a9
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
IMPORTANCE: Normal
Message-Id: <20090707112112.6D66F216C3A@f52.poczta.interia.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1387
Lines: 24

Please revert the commit 4148df9b0f38bdd362dd91d52076926c11cbe5a9 "fb: Initialize fb_info mutexes in framebuffer_alloc()".

At this point it does not fix any bug since all four affected drivers (sisfb, matroxfb, sm501fb and mx3fb) are fixed by now.

This commit breaks all drivers which do not allocate fb_info structure dynamically and there are about 10 of such drivers. This is perfectly valid for devices with built-in single framebuffer controller without ability to attach something else (e.g pxafb is an affected by the commit). Fixing some of these drivers requires heavy rewriting for the ones like matroxfb and pxafb.

An alternate patch to fix the issue with the sm501fb has been posted here for Paul to test:

http://patchwork.kernel.org/patch/34165/

This patch is a better way to fix the issue as it makes the code shorter and faster start of the framebuffer. However, the previous Paul's fix to the sm501fb is enough and this patch is a proposition for him.

Regards,
Krzysztof

----------------------------------------------------------------------
Wybierz najlepsze ubezpieczenie komunikacyjne.
http://link.interia.pl/f222d

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/