Date: Tue, 7 Jul 2009 15:51:48 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Gregory Haskins <ghaskins@novell.com>, kvm@vger.kernel.org,
       linux-kernel@vger.kernel.org, Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support
Message-ID: <20090707125148.GE3647@redhat.com>
References: <20090706202742.14222.65548.stgit@dev.haskins.net> <20090706203321.14222.67866.stgit@dev.haskins.net> <20090707112024.GA3647@redhat.com> <4A53372E.6090509@redhat.com> <20090707122250.GC3647@redhat.com> <4A533F45.90609@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A533F45.90609@redhat.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1202
Lines: 45

On Tue, Jul 07, 2009 at 03:27:49PM +0300, Avi Kivity wrote:
> On 07/07/2009 03:22 PM, Michael S. Tsirkin wrote:
>> On Tue, Jul 07, 2009 at 02:53:18PM +0300, Avi Kivity wrote:
>>    
>>>>> +		/* address-range must be precise for a hit */
>>>>>
>>>>>          
>>>> So there's apparently no way to specify that
>>>> you want 1,2, or 4 byte writes at address X?
>>>>
>>>>        
>>> Why would you want that?
>>>      
>>
>> Donnu. Why would anyone want to catch 8 byte writes at all?
>>    
>
> One of the natural write sizes.
>
>> Seriously, why add artificial limitations?
>> IMO, addr=0,len=1 and addr=0,len=2 should not conflict.
>>
>>    
>
> They should not conflict, but a two byte write need not hit a one byte  
> registration.

Yes. That's exactly what I'm saying. I think it should be possible to
create 2 fds:

addr = 0
len = 1
addr = 0
len = 2
and at most one will ever trigger.

But current code will not let you create the second one.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/