Date: Tue, 7 Jul 2009 15:58:23 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Gregory Haskins <ghaskins@novell.com>, kvm@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support
Message-ID: <20090707125823.GA7578@redhat.com>
References: <20090706202742.14222.65548.stgit@dev.haskins.net> <20090706203321.14222.67866.stgit@dev.haskins.net> <20090707112024.GA3647@redhat.com> <4A533C4C.7020202@novell.com> <20090707124810.GD3647@redhat.com> <4A5345E9.6050502@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A5345E9.6050502@redhat.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 36

On Tue, Jul 07, 2009 at 03:56:09PM +0300, Avi Kivity wrote:
> On 07/07/2009 03:48 PM, Michael S. Tsirkin wrote:
>>>>> +
>>>>> +		__kvm_io_bus_unregister_dev(bus,&p->dev);
>>>>> +		iosignalfd_release(p);
>>>>>
>>>>>          
>>>> a single deassign removed multiple irqfds? Looks ugly.
>>>>
>>>>        
>>> Avi requested this general concept.
>>>      
>>
>> Really? Avi, could you explain? I would think each
>> assign needs to be matched with 1 deassign. No?
>>    
>
> Doesn't it follow naturally?

Yes.

> How can a single deassign remove multiple  
> fds (unless all were registered with exactly the same arguments)?
> Maybe we should instead detect that the duplicate iosignaldfds are  
> registered.
>
> Note that we do need to allow the same fd to be multiple times, but not  
> with exactly the same address/match etc.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/