Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757260AbZGGPaG (ORCPT ); Tue, 7 Jul 2009 11:30:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754138AbZGGP35 (ORCPT ); Tue, 7 Jul 2009 11:29:57 -0400 Received: from viefep19-int.chello.at ([62.179.121.39]:22359 "EHLO viefep19-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbZGGP35 (ORCPT ); Tue, 7 Jul 2009 11:29:57 -0400 X-SourceIP: 213.93.53.227 Subject: Re: [PATCH 2/3] Increase lockdep limits: MAX_LOCK_DEPTH From: Peter Zijlstra To: Joao Correia Cc: LKML , Amerigo Wang In-Reply-To: References: Content-Type: text/plain Date: Tue, 07 Jul 2009 17:29:52 +0200 Message-Id: <1246980592.9777.0.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 43 On Tue, 2009-07-07 at 16:25 +0100, Joao Correia wrote: > (Applies to current Linus tree, as of 2.6.31-rc2) > > As a result of increasing MAX_STACK_TRACE_ENTRIES on the previous > patch, another limit surfaced as being hit too soon. > This patch increases MAX_LOCK_DEPTH, being hit by false positives, and > turning off the locking correctness validator. > > The new value is arbitrary, but I believe the old one was too. Given > the amount of changes happening with regards to the usage of lockdep, > the previous limit is just too low and keeping it that way would > defeat the purpose of lockdep. > > > Signed-off-by: Joao Correia NAK, find the site that triggers this and fix it. holding more than 48 locks at any one time is silly. > --- > include/linux/sched.h | 2 +- > 1 files changes, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 0085d75..304231b 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1367,7 +1367,7 @@ struct task_struct { > int softirq_context; > #endif > #ifdef CONFIG_LOCKDEP > -# define MAX_LOCK_DEPTH 48UL > +# define MAX_LOCK_DEPTH 96UL > u64 curr_chain_key; > int lockdep_depth; > unsigned int lockdep_recursion; > --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/