Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755106AbZGGTGx (ORCPT ); Tue, 7 Jul 2009 15:06:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754703AbZGGTGq (ORCPT ); Tue, 7 Jul 2009 15:06:46 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:56713 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754268AbZGGTGp (ORCPT ); Tue, 7 Jul 2009 15:06:45 -0400 Date: Tue, 7 Jul 2009 15:06:43 -0400 From: Christoph Hellwig To: Paul Smith Cc: Linux XFS , christoph hellwig , david chinner , linux-kernel@vger.kernel.org Subject: Re: [2.6.27.25] assfail in xfs_attr_quiesce() during umount Message-ID: <20090707190643.GA32467@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 27 On Tue, Jul 07, 2009 at 02:42:16PM -0400, Paul Smith wrote: > According to the thread for the former, it was intended to be resolved > by "proper per-vfsmount write count in 2.6.25 as part of the per-mount > r/o patches" (C.Hellwig) > > Did those fixes indeed go into 2.6.25 (or 2.6.27 or below)? Was there > something else that needed to be done for XFS to be able take advantage > of that enhancement? We haven't fixed the VFS issues yet. In some later kernel we just changed the assert to a warn on for now until the issue is sorted out. > And, is the patch posted by DavidC here: > http://marc.info/?l=linux-kernel&m=120106649923499&w=2 It looks somehwat dangerous for me. For now I would just comment out the assert or change it to a WARN_ON as in the newer kernels. I've recently started looking at that area in the VFS again and I'll hopefully make progress on a solution that sets MS_RDONLY at the correct time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/