Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759293AbZGHI44 (ORCPT ); Wed, 8 Jul 2009 04:56:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753163AbZGHI4s (ORCPT ); Wed, 8 Jul 2009 04:56:48 -0400 Received: from casper.infradead.org ([85.118.1.10]:40538 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbZGHI4r (ORCPT ); Wed, 8 Jul 2009 04:56:47 -0400 Subject: Re: Possible memory leak in request_firmware() From: David Woodhouse To: Ming Lei Cc: Catalin Marinas , Cornelia Huck , Greg Kroah-Hartman , linux-kernel , Sachin Sant In-Reply-To: References: <1246979820.9451.71.camel@pc1117.cambridge.arm.com> <20090707190125.61920d00@gondolin> <1247003445.5710.7.camel@pc1117.cambridge.arm.com> <1247034519.15903.3.camel@macbook.infradead.org> Content-Type: text/plain Date: Wed, 08 Jul 2009 09:56:34 +0100 Message-Id: <1247043394.25994.0.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 18 On Wed, 2009-07-08 at 16:42 +0800, Ming Lei wrote: > > IMHO, No. > If nr_pages is not cleaned, pages pointed by pages[] will be freed > by fw_dev_release, but they should be freed by vfree() > in release_firmware. Right? Yes, sorry -- you're right, and the original patch is fine. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/