Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758262AbZGHW2G (ORCPT ); Wed, 8 Jul 2009 18:28:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755479AbZGHW1x (ORCPT ); Wed, 8 Jul 2009 18:27:53 -0400 Received: from mail-bw0-f225.google.com ([209.85.218.225]:59458 "EHLO mail-bw0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755123AbZGHW1w convert rfc822-to-8bit (ORCPT ); Wed, 8 Jul 2009 18:27:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=ZKakE+wZVtF67SP/5B3hg9Bgh9g3Xu9uLlM1Rn9he3stqFMlxm5U5j96R1j0dpg+ju 3bVcS9Ob+PU7Cup6hrqoItZJmjsCduHqkQ3SDATSOCUj4/laesK+6gen4H/4cHQAkKMA IK1aS39tSWOcFRX9NT27+2x6nhu3wd0H4AjCE= MIME-Version: 1.0 In-Reply-To: <20090708220749.GA3666@ami.dom.local> References: <200907031326.21822.andres@anarazel.de> <200907071811.27570.andres@anarazel.de> <20090708080852.GC3148@ami.dom.local> <200907081029.34527.andres@anarazel.de> <20090708091344.GD3148@ami.dom.local> <20090708220749.GA3666@ami.dom.local> From: Joao Correia Date: Wed, 8 Jul 2009 23:27:30 +0100 Message-ID: Subject: Re: Soft-Lockup/Race in networking in 2.6.31-rc1+195 ( possibly?caused by netem) To: Jarek Poplawski Cc: Andres Freund , Arun R Bharadwaj , Thomas Gleixner , Stephen Hemminger , netdev@vger.kernel.org, LKML Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 49 On Wed, Jul 8, 2009 at 11:07 PM, Jarek Poplawski wrote: > On Wed, Jul 08, 2009 at 10:44:47PM +0100, Joao Correia wrote: >> Hello again > Hello! > > ... >> So again, the only thing that stops that freeze is ?`echo 0 >> >> /proc/sys/kernel/timer_migration`. Apologies for pointing you in the >> wrong direction. > > No problem: the direction is almost right, we only need one U-turn ;-) > In case you're not bored or too bored, one little patch to check the > other side (after reverting the previous patch). > > Thanks, > Jarek P. > --- > > ?kernel/hrtimer.c | ? ?2 +- > ?1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c > index 9002958..23387e4 100644 > --- a/kernel/hrtimer.c > +++ b/kernel/hrtimer.c > @@ -203,7 +203,7 @@ switch_hrtimer_base(struct hrtimer *timer, struct hrtimer_clock_base *base, > ? ? ? ?int cpu, preferred_cpu = -1; > > ? ? ? ?cpu = smp_processor_id(); > -#if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP) > +#if 0 > ? ? ? ?if (!pinned && get_sysctl_timer_migration() && idle_cpu(cpu)) { > ? ? ? ? ? ? ? ?preferred_cpu = get_nohz_load_balancer(); > ? ? ? ? ? ? ? ?if (preferred_cpu >= 0) > (this time i triple-checked :-) ) So, with only this last patch applied, no freeze. No need to disable anything through /proc. Where should i put the BUG_ON? Joao Correia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/