DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:from:date:message-id:subject:to:cc:content-type
         :content-transfer-encoding;
        b=cWt5xvcWrBhy1rroCmIflsjiNYQSTyS8eBkD9yOROT6g79fy63YUM4l8zniKlcFBLr
         qtmKLkXpwu3kE8uECA/HM2ahcJIdOPEETwEECyuHH+br4SP6cUXx0ev/v7h6n0HdlUFs
         CRy7gRgml9rUaH9y3MTFxTMDz8bAy2Iezj0yI=
MIME-Version: 1.0
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Thu, 9 Jul 2009 04:04:31 -0400
Message-ID: <8bd0f97a0907090104h5d4984dfkbeb82616a01128c8@mail.gmail.com>
Subject: truncate on MAP_SHARED files in ramfs filesystems on no-mmu
To: David Howells <dhowells@redhat.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1120
Lines: 28

reviewing LTP tests shows mmap09 failing.  this test creates a file of
a certain length, opens it and creates a shared mapping, and then
tries various truncate tests:
truncate to a smaller size
truncate to a larger size
truncate to size 0

the first and last fail on no-mmu due to
file-nommu.c:ramfs_nommu_resize() rejecting attempts to shrink on a
shared mapping:
    /* check that a decrease in size doesn't cut off any shared mappings */
    if (newsize < size) {
        ret = ramfs_nommu_check_mappings(inode, newsize, size);
        if (ret < 0)
            return ret;
    }

my question is why ?  if an application maps a fd with MAP_SHARED,
truncates it, and then it or someone else who has that fd mapped tries
to access the now-invalid tail end, that is a bug in the application.
i dont see why we should be protecting users here from their own buggy
code ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/