Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759945AbZGIIMU (ORCPT ); Thu, 9 Jul 2009 04:12:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758629AbZGIIMI (ORCPT ); Thu, 9 Jul 2009 04:12:08 -0400 Received: from brick.kernel.dk ([93.163.65.50]:58268 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756238AbZGIIMG (ORCPT ); Thu, 9 Jul 2009 04:12:06 -0400 Date: Thu, 9 Jul 2009 10:12:05 +0200 From: Jens Axboe To: FUJITA Tomonori Cc: James.Bottomley@HansenPartnership.com, dwalker@fifo99.com, maciej.rutecki@gmail.com, akpm@linux-foundation.org, tarkan.erimer@turknet.net.tr, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media Message-ID: <20090709081204.GI23611@kernel.dk> References: <20090708165728.GU23611@kernel.dk> <20090709084839G.fujita.tomonori@lab.ntt.co.jp> <20090709075004.GH23611@kernel.dk> <20090709170727S.fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090709170727S.fujita.tomonori@lab.ntt.co.jp> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2219 Lines: 60 On Thu, Jul 09 2009, FUJITA Tomonori wrote: > On Thu, 9 Jul 2009 09:50:04 +0200 > Jens Axboe wrote: > > > On Thu, Jul 09 2009, FUJITA Tomonori wrote: > > > From: FUJITA Tomonori > > > Subject: [PATCH] block: call blk_scsi_ioctl_init() > > > > > > Currently, blk_scsi_ioctl_init() is not called so > > > blk_default_cmd_filter isn't initalized. Some commands are not blocked > > > wrongly. > > > > > > This fixes a regression introduced: > > > > > > commit 018e0446890661504783f92388ecce7138c1566d > > > Author: Jens Axboe > > > Date: Fri Jun 26 16:27:10 2009 +0200 > > > > > > block: get rid of queue-private command filter > > > > > > Signed-off-by: FUJITA Tomonori > > > --- > > > block/scsi_ioctl.c | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c > > > index f0e0ce0..e5b1001 100644 > > > --- a/block/scsi_ioctl.c > > > +++ b/block/scsi_ioctl.c > > > @@ -680,3 +680,4 @@ int __init blk_scsi_ioctl_init(void) > > > blk_set_cmd_filter_defaults(&blk_default_cmd_filter); > > > return 0; > > > } > > > +fs_initcall(blk_scsi_ioctl_init); > > > -- > > > 1.6.0.6 > > > > You beat me to it, it was the missing call as I suspected. This > > works, I verified it myself. Applied to for-linus, going upstream > > soon. > > I really hope that you become more serious about not causing such > incident; breaking mainline kernel by merging your trivial patch after > -rc1 (even without sending the patch to any mailing list). You broke > mainline in the exact same way just months ago (the commit > 1e42807918d17e8c93bf14fbb74be84b141334c1 in 2.6.29-rc7). It should have waited for .32, I agree. I had it sitting around for quite a while, not sure why the merged version didn't have the initcall added. But yes, I should have posted and postponed it. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/