Date: Thu, 9 Jul 2009 10:48:40 +0200
From: Daniel Mack <daniel@caiaq.de>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-kernel@vger.kernel.org,
       Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
       Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>, rjw@sisk.pl,
       mingo@elte.hu, Shaohua Li <shaohua.li@intel.com>,
       Pekka Enberg <penberg@cs.helsinki.fi>,
       Dave Young <hidave.darkstar@gmail.com>,
       Rusty Russell <rusty@rustcorp.com.au>, sven.wegener@stealer.net,
       cpufreq@vger.kernel.org, Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] cpufreq: Unbreak build for !SMP: symlinked cpus cannot
	happen for !SMP
Message-ID: <20090709084840.GR9464@buzzloop.caiaq.de>
References: <1247081067-21964-1-git-send-email-daniel@caiaq.de> <200907091043.39607.trenn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200907091043.39607.trenn@suse.de>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1531
Lines: 49

On Thu, Jul 09, 2009 at 10:43:35AM +0200, Thomas Renninger wrote:
> Or like that:
> Either all #ifdef CONFIG_SMP related conditionals to managed cpus
> should vanish or all should be covered. This one takes the latter
> approach.

Dave Jones fixed it already, see

  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5e1596f75395e7a402e1059c518e633d2732dcf8

Daniel


> ---
> 'managed_policy' is used for the non-smp case in line 941.
> 
> Make the symlink code conditional to #ifdef CONFIG_SMP as already
> done at other places.
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> 
> Index: cpufreq/drivers/cpufreq/cpufreq.c
> ===================================================================
> --- cpufreq.orig/drivers/cpufreq/cpufreq.c
> +++ cpufreq/drivers/cpufreq/cpufreq.c
> @@ -930,6 +930,7 @@ static int cpufreq_add_dev(struct sys_de
>  	}
>  	spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
>  
> +#ifdef CONFIG_SMP
>  	/* symlink affected CPUs */
>  	for_each_cpu(j, policy->cpus) {
>  		if (j == cpu)
> @@ -947,6 +948,7 @@ static int cpufreq_add_dev(struct sys_de
>  			goto err_out_unregister;
>  		}
>  	}
> +#endif
>  
>  	policy->governor = NULL; /* to assure that the starting sequence is
>  				  * run in cpufreq_set_policy */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/