Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760591AbZGIM6U (ORCPT ); Thu, 9 Jul 2009 08:58:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760004AbZGIM6F (ORCPT ); Thu, 9 Jul 2009 08:58:05 -0400 Received: from waste.org ([66.93.16.53]:46409 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759040AbZGIM6D (ORCPT ); Thu, 9 Jul 2009 08:58:03 -0400 Subject: Re: [PATCH] netpoll: Fix carrier detection for drivers that are using phylib From: Matt Mackall To: Peter Zijlstra Cc: Linus Torvalds , Anton Vorontsov , Andrew Morton , oleg@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <1247126210.9777.317.camel@twins> References: <20090707235812.GA12824@oksana.dev.rtsoft.ru> <20090708005000.GA12380@redhat.com> <1247034263.9777.24.camel@twins> <20090708141024.f8b581c5.akpm@linux-foundation.org> <20090708213331.GA9346@oksana.dev.rtsoft.ru> <20090708144744.5555b88d.akpm@linux-foundation.org> <20090708222003.GA12318@oksana.dev.rtsoft.ru> <1247126210.9777.317.camel@twins> Content-Type: text/plain Date: Thu, 09 Jul 2009 07:56:42 -0500 Message-Id: <1247144202.21295.869.camel@calx> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 25 On Thu, 2009-07-09 at 09:56 +0200, Peter Zijlstra wrote: > On Wed, 2009-07-08 at 17:01 -0700, Linus Torvalds wrote: > > Looking at the people looking at SYSTEM_RUNNING, I do note some odd cases. > > Why the heck does kernel/perf_counter.c do it, for example? > > Ah, those are the swcounter and other probe entry points. I've had > several cases where we called into the perf counter code from those > points before it was initialized, getting in kernel segfaults due to > dereferencing uninitialized data etc.. > > I could keep a variable that tracked the perf_counter_init() state, and > use that instead if you prefer? Looks like that'd be more accurate. Linus's proposed patch might break your current assumptions. -- http://selenic.com : development and support for Mercurial and Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/