Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761337AbZGIOqS (ORCPT ); Thu, 9 Jul 2009 10:46:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760900AbZGIOqJ (ORCPT ); Thu, 9 Jul 2009 10:46:09 -0400 Received: from waste.org ([66.93.16.53]:47700 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760730AbZGIOqI (ORCPT ); Thu, 9 Jul 2009 10:46:08 -0400 Subject: Re: [PATCH] netpoll: Fix carrier detection for drivers that are using phylib From: Matt Mackall To: Peter Zijlstra Cc: Linus Torvalds , Anton Vorontsov , Andrew Morton , oleg@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <1247149862.12784.6.camel@twins> References: <20090707235812.GA12824@oksana.dev.rtsoft.ru> <20090708005000.GA12380@redhat.com> <1247034263.9777.24.camel@twins> <20090708141024.f8b581c5.akpm@linux-foundation.org> <20090708213331.GA9346@oksana.dev.rtsoft.ru> <20090708144744.5555b88d.akpm@linux-foundation.org> <20090708222003.GA12318@oksana.dev.rtsoft.ru> <1247145977.21295.899.camel@calx> <1247147206.7439.2.camel@twins> <1247149093.21295.915.camel@calx> <1247149862.12784.6.camel@twins> Content-Type: text/plain Date: Thu, 09 Jul 2009 09:43:00 -0500 Message-Id: <1247150580.21295.937.camel@calx> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1357 Lines: 42 On Thu, 2009-07-09 at 16:31 +0200, Peter Zijlstra wrote: > On Thu, 2009-07-09 at 09:18 -0500, Matt Mackall wrote: > > > > Sorry if I was unclear. I'm suggesting setting the count so the existing > > PREEMPT_ACTIVE test here fires: > > > > int __sched _cond_resched(void) > > { > > if (need_resched() && !(preempt_count() & PREEMPT_ACTIVE) && > > system_state == SYSTEM_RUNNING) { > > __cond_resched(); > > return 1; > > } > > return 0; > > } > > Right, /me read preempt and thought a simple preempt inc but didn't read > the code. Shame on me. > > So something like (utterly untested and such) Yeah, that's what I had in mind. Probably throw in a define: /* for disabling scheduling in early boot */ #define PREEMPT_EARLY (1 + PREEMPT_ACTIVE) and slap a comment on the sub_preempt_count(). Does anything actually use scheduler_running yet? Perhaps my tree is old. Also, might_sleep's use of system_state probably bears revisiting. -- http://selenic.com : development and support for Mercurial and Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/