Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754961AbZGITmj (ORCPT ); Thu, 9 Jul 2009 15:42:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753632AbZGITmb (ORCPT ); Thu, 9 Jul 2009 15:42:31 -0400 Received: from msux-gh1-uea01.nsa.gov ([63.239.67.1]:42793 "EHLO msux-gh1-uea01.nsa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbZGITmb (ORCPT ); Thu, 9 Jul 2009 15:42:31 -0400 Subject: Re: [PATCH] Security/sysfs: Enable security xattrs to be set on sysfs files, directories, and symlinks. From: "David P. Quigley" To: Greg KH Cc: Casey Schaufler , jmorris@namei.org, sds@tycho.nsa.gov, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org In-Reply-To: <20090709175049.GA26378@suse.de> References: <1247074106-23405-1-git-send-email-dpquigl@tycho.nsa.gov> <4A554B95.6070709@schaufler-ca.com> <1247160404.4398.218.camel@localhost> <20090709175049.GA26378@suse.de> Content-Type: text/plain Organization: National Security Agency Date: Thu, 09 Jul 2009 15:32:56 -0400 Message-Id: <1247167976.4398.231.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 32 On Thu, 2009-07-09 at 10:50 -0700, Greg KH wrote: > On Thu, Jul 09, 2009 at 01:26:44PM -0400, David P. Quigley wrote: > > I just read over Casey's comments again and I'm pretty sure we have a > > big misunderstanding here. From his initial response it seems that he > > thinks that I am exposing the secids to userspace as the way for setting > > the labels on files. That isn't true. We are still using the full string > > based labels for the userspace interface what the secid is used for is > > to allow the kernel to keep track of changes until the sysfs_dirent is > > destroyed. > > Ok, if Casey and others agree that this is the best solution, I'll take > it. > > thanks, > > greg k-h I haven't heard from Casey since his last email so I'd hold off on taking this until we come to an agreement. It seems though from your comments in another mail that putting the persistent data into the sysfs_dirent is the proper approach and we just need to figure out what to put there. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/