Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750948AbZGIXFw (ORCPT ); Thu, 9 Jul 2009 19:05:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750717AbZGIXFo (ORCPT ); Thu, 9 Jul 2009 19:05:44 -0400 Received: from tundra.namei.org ([65.99.196.166]:45640 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750695AbZGIXFn (ORCPT ); Thu, 9 Jul 2009 19:05:43 -0400 Date: Fri, 10 Jul 2009 09:04:47 +1000 (EST) From: James Morris To: Oleg Nesterov cc: Andrew Morton , David Howells , "Paul E. McKenney" , Roland McGrath , Stephen Smalley , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm 1/2] rename is_single_threaded(task) to is_current_single_threaded(void) In-Reply-To: <20090709212847.GA10238@redhat.com> Message-ID: References: <20090709212847.GA10238@redhat.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 24 On Thu, 9 Jul 2009, Oleg Nesterov wrote: > (on top of rework-fix-is_single_threaded.patch) > > - is_single_threaded(task) is not safe unless task == current, > we can't use task->signal or task->mm. > > - it doesn't make sense unless task == current, the task can > fork right after the check. > > Rename it to is_current_single_threaded() and kill the argument. > > Signed-off-by: Oleg Nesterov Acked-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/