Date: Fri, 10 Jul 2009 01:21:39 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
       charles.f.johnson@intel.com
Subject: Re: [PATCH] This is the security processor driver for the Intel
	mid platform
Message-ID: <20090709232139.GF1469@ucw.cz>
References: <1247083262-17356-1-git-send-email-mark.a.allyn@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1247083262-17356-1-git-send-email-mark.a.allyn@intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1185
Lines: 52


> + *
> + *  CHANGES:
> + *
> + *  2009.06.26	Initial publish
> + * 
> + */

No changelogs in source files, please...

> +
> +  /* start address of resident */

Eh?

> +  unsigned long   message_size_in_words;
> +
> +};

> +struct sep_driver_realloc_cache_resident_t {
> +  /* base address */
> +  unsigned long   base_addr;

Most useless comment, ever.

> +  /* cache size in bytes*/
> +  unsigned long   cache_size_in_bytes;

...and more.
 
> +  /* new resident address */
> +  unsigned long   new_resident_addr;
> +
> +  /* new resident address */
> +  unsigned long   new_shared_area_addr;

Ouch. Copy & paste error?

> +  /* new base address */
> +  unsigned long   new_base_addr;

Did they tell you you have to document it, so you did? Bad comments
 are worse than no comments...  
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/