Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757336AbZGJMqA (ORCPT ); Fri, 10 Jul 2009 08:46:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755597AbZGJMkb (ORCPT ); Fri, 10 Jul 2009 08:40:31 -0400 Received: from casper.infradead.org ([85.118.1.10]:55299 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755614AbZGJMk3 (ORCPT ); Fri, 10 Jul 2009 08:40:29 -0400 Subject: Re: [PATCH 2:2][MTD][NAND]omap : Adding DMA mode support in nand prefetch/post-write From: David Woodhouse To: dedekind@infradead.org Cc: vimal singh , linux-mtd@lists.infradead.org, Tony Lindgren , david-b@pacbell.net, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org In-Reply-To: <1247227344.20721.363.camel@localhost.localdomain> References: <63362.192.168.10.89.1247226916.squirrel@dbdmail.itg.ti.com> <1247227344.20721.363.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 10 Jul 2009 13:40:21 +0100 Message-Id: <1247229621.29541.4.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 21 On Fri, 2009-07-10 at 15:02 +0300, Artem Bityutskiy wrote: > On Fri, 2009-07-10 at 17:25 +0530, vimal singh wrote: > > + /* The fifo depth is 64 bytes. We have a sync at each frame and frame > > + * length is 64 bytes. > > + */ > > + int buf_len = len/64; > > To optimize performance it is better not to rely on gcc and use << If you ever see gcc screwing up division of an 'int' by a constant 64, file a GCC bug. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/