From: Robin Getz <rgetz@blackfin.uclinux.org>
Organization: Blackfin uClinux org
To: "Ingo Molnar" <mingo@elte.hu>
Subject: Re: [PATCH] kernel.printk.c - ensure that "console enabled"messages are printed on the console
Date: Fri, 10 Jul 2009 10:13:56 -0400
User-Agent: KMail/1.9.5
CC: "Andrew Morton" <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       "Linus Torvalds" <torvalds@linux-foundation.org>
References: <200907040017.26921.rgetz@blackfin.uclinux.org> <200907091308.37370.rgetz@blackfin.uclinux.org> <20090710102547.GD5499@elte.hu>
In-Reply-To: <20090710102547.GD5499@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200907101013.56177.rgetz@blackfin.uclinux.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1968
Lines: 52

On Fri 10 Jul 2009 06:25, Ingo Molnar pondered:
> 
> * Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> 
> > From: Robin Getz <rgetz@blackfin.uclinux.org>
> > 
> > Today, when a console is registered without CON_PRINTBUFFER, end 
> > users never see the announcement of it being added, and never know 
> > if they missed something, if the console is really at the start or 
> > not, and just leads to general confusion.
> > 
> > This re-orders existing code, to make sure the console is added, 
> > before the "console [%s%d] enabled" is printed out - ensuring that 
> > this message is _always_ seen.
> > 
> > This has the desired/intended side effect of making sure that 
> > "console enabled:" messages are printed on the bootconsole, and 
> > the real console. This does cause the same line is printed twice 
> > if the bootconsole and real console are the same device, but if 
> > they are on different devices, the message is printed to both 
> > consoles.
> > 
> > Signed-off-by : Robin Getz <rgetz@blackfin.uclinux.org>
> > 
> > ---
> > 
> >  printk.c |   44 +++++++++++++++++++++++++++++---------------
> >  1 file changed, 29 insertions(+), 15 deletions(-)
> > 
> > patch generated for -tip
> 
> Looks good, applied it to tip:core/printk for v2.6.32, thanks Robin. 
> 
> i fixed a couple of small details in the patch:
> 
>  - re-broke the commit log as it was too wide for nice git log 
>    output

Hmm - I didn't know there was a restriction on this - what is the number?

>  - fixed a stray whitespace warned about by scripts/checkpatch.pl
>  - fixed another stray whitespace found the old fashioned way
>  - fixed the patch title to match the prefix used by your previous 
>    commit as well

Thanks
-Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/