Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755216AbZGJPrT (ORCPT ); Fri, 10 Jul 2009 11:47:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751483AbZGJPrO (ORCPT ); Fri, 10 Jul 2009 11:47:14 -0400 Received: from turing-police.cc.vt.edu ([128.173.14.107]:60772 "EHLO turing-police.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbZGJPrN (ORCPT ); Fri, 10 Jul 2009 11:47:13 -0400 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Linus Torvalds , Matt Mackall , Anton Vorontsov , Andrew Morton , oleg@redhat.com, mingo@elte.hu, tony.luck@intel.com, rth@twiddle.net, geert@linux-m68k.org Subject: Re: [PATCH 1/2] sched: INIT_PREEMPT_COUNT In-Reply-To: Your message of "Fri, 10 Jul 2009 14:57:56 +0200." <20090710130125.037018244@chello.nl> From: Valdis.Kletnieks@vt.edu References: <20090710125755.559739294@chello.nl> <20090710130125.037018244@chello.nl> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1247240546_3858P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Fri, 10 Jul 2009 11:42:26 -0400 Message-ID: <17047.1247240546@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 39 --==_Exmh_1247240546_3858P Content-Type: text/plain; charset=us-ascii On Fri, 10 Jul 2009 14:57:56 +0200, Peter Zijlstra said: > +/* > + * Disable preemption until the scheduler is running. > + * Reset by start_kernel()->sched_init()->init_idle(). > + */ > +#define INIT_PREEMPT_COUNT (1) > + I had to look at this for quite some time before it sank in that it wasn't a reset of a #define, or a reset of (1) (anybody else remember changing the value of '5' in a Fortran program?). Especially when stuck in with a bunch of cputimer defines. Would have taken even longer if I was looking in sched.h for something and not looking at this patch at the same time. Can we fix this comment to mention it's thread_info.preempt_count that needs the reset? --==_Exmh_1247240546_3858P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFKV2FicC3lWbTT17ARAnoRAJ4qyvpK+r/gaFG63FLWMt2ZqXjl7ACfSveu PlK95waFksNCIHON+oex5JI= =E2Xr -----END PGP SIGNATURE----- --==_Exmh_1247240546_3858P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/