DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=OX6qemEjEkObDD12L5tvbCPJGnf8kD/fTTgUkRdK/RwxPXgPfn8djt3Fjw9VAM4jHr1UaxnPTMNuaW8zsBQjGQVanL89muites8zICF57SJGr24qO4YWBhnnqTDdSlSPgBT3KU/k7ZEa7DWzVKbEbIdaY6pKIIW2YOv4EktWqwA=  ;
From: David Brownell <david-b@pacbell.net>
To: "vimal singh" <vimalsingh@ti.com>
Subject: Re: [PATCH 1:2] [MTD][NAND]omap: Adding support for nand prefetch-read  and post-write, in MPU mode.
Date: Fri, 10 Jul 2009 11:01:57 -0700
User-Agent: KMail/1.9.10
Cc: linux-mtd@lists.infradead.org, "Tony Lindgren" <tony@atomide.com>,
       dwmw2@infradead.org, dedekind@infradead.org,
       linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
References: <61339.192.168.10.89.1247226724.squirrel@dbdmail.itg.ti.com>
In-Reply-To: <61339.192.168.10.89.1247226724.squirrel@dbdmail.itg.ti.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200907101101.58029.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 23

On Friday 10 July 2009, vimal singh wrote:
> +static void omap_read_buf8(struct mtd_info *mtd, u_char *buf, int len)
> +{
> +???????struct nand_chip *nand = mtd->priv;
> +???????u_char *p = (u_char *)buf;
> +
> +???????while (len--)
> +???????????????*p++ = __raw_readb(nand->IO_ADDR_R);
> +}

Better as __raw_readsb() yes?  Or maybe ioread8_rep().

... speaking of which, maybe the MTD layer can finally
default to using the accelerated block PIO calls, now
that ioreadX_rep() is supposed to work on all arches...

Last time I measured, that change alone was worth
something like a 10% speedup.  Maybe more.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/