DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=dk20050327; d=earthlink.net;
  b=ETBUO8ZmUtVq3xOXUtSxpSsu3jcS/BTrmVU5q4DdJggzF2EfM8tjIj59CsiwSnl6;
  h=Received:Cc:Message-Id:From:To:In-Reply-To:Content-Type:Content-Transfer-Encoding:Mime-Version:Subject:Date:References:X-Mailer:X-ELNK-Trace:X-Originating-IP;
Cc: linux-kernel@vger.kernel.org
Message-Id: <2AF5E97B-E5D6-4302-9C13-30B2270F15D3@earthlink.net>
From: Mitchell Erblich <erblichs@earthlink.net>
To: Mitchell Erblich <erblichs@earthlink.net>
In-Reply-To: <F4B972C6-3FAB-49DB-A409-36B5EF2A7684@earthlink.net>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Subject: Re: Suggested code change : Simple : Scale pdflush threads from desktop to server
Date: Fri, 10 Jul 2009 18:48:39 -0700
References: <F4B972C6-3FAB-49DB-A409-36B5EF2A7684@earthlink.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1620
Lines: 58

Sorry,

	IF Not rate limit. Missing not / !.
	if (!(printk_ratelimit() )) {


	Mitchell Erblich	
	================
	
On Jul 10, 2009, at 6:25 PM, Mitchell Erblich wrote:

> Group,
>
> 		pdflush threads clean dirty pages
>
> 	  Under the past simple assumption that a greater number of
> 	  page daemon threads will have the TENDENCY to clean
> 	  the pages faster.
>
> 	Another assumption is that a server will have at least 2x / 4x the
> 	number of drives and memory, so allocating more pdflush() threads
> 	makes sense.
>
> 	Relying on a recent change, code base on whether the system is
> 	a desktop or a server, scale the number of pdthreads() which would
> 	result in the below code change.
>
> 	The suggestion is to double the MIN number of threads and set the
> 	MAX number to 4x.
>
> 	./mm/pdflush.c
> 	/* Scale for a server */
> 	#define MIN_PDFLUSH_THREADS 	4		/* 2x desktop value */
> 	#define MAX_PDFLUSH_THREADS 	32		/* 4x desktop value */
>
>
> 	/*
> 	 * secondary suggestion is to add a DEBUG type /var/log/system  
> messages that
> 	 * will rate limit independent of desktop or server.
>         */
>
> 	else if (nr_pdflush_threads == MAX_PDFLUSH_THREADS) {
> 		   /* optional PDFLUSH msg */
> 		   if (printk_ratelimit() {
> 	 		                            printk(KERN_INFO  
> "MAX_PDFLUSH_THREADS Limited\n");
>                   }
>         }
> 	
>
> 	

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/