Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Julia Lawall <julia@diku.dk>, gregkh@suse.de, devel@driverdev.osuosl.org,
       linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
In-Reply-To: <4A584A94.5010105@gmail.com>
References: <Pine.LNX.4.64.0907110950510.29592@ask.diku.dk>
	 <4A584A94.5010105@gmail.com>
Content-Type: text/plain
Date: Sat, 11 Jul 2009 15:47:24 +0530
Message-Id: <1247307444.3032.2.camel@hpdv5.satnam>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1047
Lines: 38

On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote:
> On 07/11/2009 09:51 AM, Julia Lawall wrote:
> > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> > --- a/drivers/staging/otus/wwrap.c
> > +++ b/drivers/staging/otus/wwrap.c
> > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
> >  {
> >      struct usbdrv_private *macp =
> >                 container_of(work, struct usbdrv_private, kevent);
> > -    zdev_t *dev = macp->device;
> > +    zdev_t *dev;
> >  
> >      if (macp == NULL)
> >      {
> >          return;
> >      }
> 
> The test is rather useless here.
> 

Why useless, it should be non-null before setting to dev.

But issue is why function name like kevent() is global and who is using
it.

> > +    dev = macp->device;
> 
> 

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/