Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755714AbZGKKdC (ORCPT ); Sat, 11 Jul 2009 06:33:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754960AbZGKKcw (ORCPT ); Sat, 11 Jul 2009 06:32:52 -0400 Received: from hera.kernel.org ([140.211.167.34]:50368 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754348AbZGKKcw (ORCPT ); Sat, 11 Jul 2009 06:32:52 -0400 Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test From: Jaswinder Singh Rajput To: Jiri Slaby , "Luis R. Rodriguez" Cc: Julia Lawall , gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <1247307444.3032.2.camel@hpdv5.satnam> References: <4A584A94.5010105@gmail.com> <1247307444.3032.2.camel@hpdv5.satnam> Content-Type: text/plain Date: Sat, 11 Jul 2009 16:02:03 +0530 Message-Id: <1247308323.3032.5.camel@hpdv5.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-2.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 45 On Sat, 2009-07-11 at 15:47 +0530, Jaswinder Singh Rajput wrote: > On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote: > > On 07/11/2009 09:51 AM, Julia Lawall wrote: > > > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c > > > --- a/drivers/staging/otus/wwrap.c > > > +++ b/drivers/staging/otus/wwrap.c > > > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work) > > > { > > > struct usbdrv_private *macp = > > > container_of(work, struct usbdrv_private, kevent); > > > - zdev_t *dev = macp->device; > > > + zdev_t *dev; > > > > > > if (macp == NULL) > > > { > > > return; > > > } > > > > The test is rather useless here. > > > > Why useless, it should be non-null before setting to dev. > > But issue is why function name like kevent() is global and who is using > it. > > > > + dev = macp->device; > > > > > And more funny thing is that all functions are global in this file. Greg, can you please check the scope of these function, why all are global. Thanks, -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/