Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753784AbZGKSUN (ORCPT ); Sat, 11 Jul 2009 14:20:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751615AbZGKSUC (ORCPT ); Sat, 11 Jul 2009 14:20:02 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51898 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbZGKSUB (ORCPT ); Sat, 11 Jul 2009 14:20:01 -0400 Date: Sat, 11 Jul 2009 11:19:28 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Trond Myklebust cc: Larry Finger , linux-kernel@vger.kernel.org Subject: RE: commit 097041e576ee3a50d92dd643ee8ca65bf6a62e21 (fuse: Fix build error) In-Reply-To: <1247321214.5615.6.camel@heimdal.trondhjem.org> Message-ID: References: <1247321214.5615.6.camel@heimdal.trondhjem.org> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 20 On Sat, 11 Jul 2009, Trond Myklebust wrote: > > Please revert this commit. Instead of fixing the compile problem, it > adds a new dependency on CONFIG_BLOCK to both NFS and FUSE. Neither one > of them has such a dependency today, nor is there a reason to introduce > one. > > The correct fix should rather be to move the definitions of BLK_RW_SYNC > and BLK_RW_ASYNC into backing-dev.h as per the patch below. Right you are. Thanks, Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/