Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbZGKTIM (ORCPT ); Sat, 11 Jul 2009 15:08:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752724AbZGKTH6 (ORCPT ); Sat, 11 Jul 2009 15:07:58 -0400 Received: from mx-out2.daemonmail.net ([216.104.160.39]:59843 "EHLO mx-out2.daemonmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbZGKTH5 (ORCPT ); Sat, 11 Jul 2009 15:07:57 -0400 From: "Michael S. Zick" Reply-To: lkml@morethan.org To: Alan Stern Subject: uhci_hcd fails to off-line device/hub on error condition Date: Sat, 11 Jul 2009 14:07:51 -0500 User-Agent: KMail/1.9.9 Cc: Oliver Neukum , Jiri Kosina , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <200907081130.07370.lkml@morethan.org> <200907081138.39211.lkml@morethan.org> In-Reply-To: <200907081138.39211.lkml@morethan.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907111407.54152.lkml@morethan.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6501 Lines: 166 On Wed July 8 2009, Michael S. Zick wrote: > On Wed July 8 2009, Michael S. Zick wrote: > > On Wed July 8 2009, Michael S. Zick wrote: > > > On Tue July 7 2009, Alan Stern wrote: > > > > On Tue, 7 Jul 2009, Michael S. Zick wrote: > > > > > > > > > On Tue July 7 2009, Alan Stern wrote: > > > > > > On Tue, 7 Jul 2009, Michael S. Zick wrote: > > > > > > > > > > > > > > It looks like there's a serious problem in your UHCI hardware. > > > > > > > > According to the log you posted, it's not working at all. > > > > > > > > > > > > > > > > > > > > > > I am using the x86-generic drivers - - > > > > > > > > > > > > Not a problem with the drivers, a problem in the hardware. > > > > > > > > > > > > > > > > Or hardware that works as the manufacturer intended, but differently > > > > > than expected. Same difference as "broken" when compared to "standard". > > > > > > > > No, hardware that doesn't work at all. As in "all reads return > > > > 0xffffffff" -- that's just a guess but something like it would account > > > > for what you saw. > > > > > > I tried to combine the addition of the diagnostic print (BUG()) > statements and the potential fix - - > This is what I put into the code for today's testing: > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index be86ae3..d686f1d 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -160,8 +160,10 @@ static inline char *portspeed(int portstatus) > } > > /* Note that hdev or one of its children must be locked! */ > -static inline struct usb_hub *hdev_to_hub(struct usb_device *hdev) > +static struct usb_hub *hdev_to_hub(struct usb_device *hdev) > { > + if (!hdev || !hdev->actconfig) > + return NULL; > return usb_get_intfdata(hdev->actconfig->interface[0]); > } > > @@ -369,11 +371,16 @@ static void kick_khubd(struct usb_hub *hub) > { > unsigned long flags; > > - /* Suppress autosuspend until khubd runs */ > - to_usb_interface(hub->intfdev)->pm_usage_cnt = 1; > + if (!hub) { > + BUG(); > + return; > + } > > spin_lock_irqsave(&hub_event_lock, flags); > if (!hub->disconnected && list_empty(&hub->event_list)) { > + /* Suppress autosuspend until khubd runs */ > + to_usb_interface(hub->intfdev)->pm_usage_cnt = 1; > + > list_add_tail(&hub->event_list, &hub_event_list); > wake_up(&khubd_wait); > } > @@ -382,8 +389,19 @@ static void kick_khubd(struct usb_hub *hub) > > void usb_kick_khubd(struct usb_device *hdev) > { > - /* FIXME: What if hdev isn't bound to the hub driver? */ > - kick_khubd(hdev_to_hub(hdev)); > + struct usb_hub *hub; > + > + if (!hdev) { > + BUG(); > + return; > + } > + hub = hdev_to_hub(hdev); > + if (hub) { > + kick_khubd(hub); > + } else { > + BUG(); > + return; > + } > } > - - Megabytes of the same snipped - - uhci_hcd 0000:00:10.2: host controller process error, something bad happened! uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! uhci_hcd 0000:00:10.2: host system error, PCI problems? uhci_hcd 0000:00:10.2: host controller process error, something bad happened! - - driver can detect unexpected behavior sufficent to post the messages - - uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! - - but never does anything about it - other than bitch - - - - insert external action: rmmod uhci_hcd here - - uhci_hcd 0000:00:10.2: remove, state 1 uhci_hcd 0000:00:10.2: roothub graceful disconnect usb usb4: USB disconnect, address 1 usb usb4: unregistering device usb usb4: usb_disable_device nuking all URBs usb usb4: unregistering interface 4-0:1.0 uhci_hcd 0000:00:10.2: host system error, PCI problems? uhci_hcd 0000:00:10.2: host controller process error, something bad happened! uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! uhci_hcd 0000:00:10.2: host system error, PCI problems? uhci_hcd 0000:00:10.2: host controller process error, something bad happened! uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! uhci_hcd 0000:00:10.2: host system error, PCI problems? uhci_hcd 0000:00:10.2: host controller process error, something bad happened! uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! uhci_hcd 0000:00:10.2: host system error, PCI problems? uhci_hcd 0000:00:10.2: host controller process error, something bad happened! uhci_hcd 0000:00:10.1: host system error, PCI problems? uhci_hcd 0000:00:10.1: host controller process error, something bad happened! usb 4-0:1.0: uevent usb usb4: uevent uhci_hcd 0000:00:10.2: USB bus 4 deregistered uhci_hcd 0000:00:10.1: remove, state 1 uhci_hcd 0000:00:10.1: roothub graceful disconnect usb usb3: USB disconnect, address 1 usb usb3: unregistering device usb usb3: usb_disable_device nuking all URBs usb usb3: unregistering interface 3-0:1.0 usb 3-0:1.0: uevent usb usb3: uevent uhci_hcd 0000:00:10.1: USB bus 3 deregistered uhci_hcd 0000:00:10.0: remove, state 0 uhci_hcd 0000:00:10.0: roothub graceful disconnect usb usb2: USB disconnect, address 1 usb usb2: unregistering device usb usb2: usb_disable_device nuking all URBs usb usb2: unregistering interface 2-0:1.0 usb 2-0:1.0: uevent usb usb2: uevent uhci_hcd 0000:00:10.0: USB bus 2 deregistered - - end event - - (with apologies to China Syndrome) Mike > Mike > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/