DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=oHgb1u/WX9tKgYAsH92EFgAICK5WnTbcrdejU+iuitxaC3g1xAJqM0PikBk/ulo9KpEvPjAhBEVgqVdcWgBFBhU+etbRzJ0lX1yFsTGKtWWAdpcOPtBJhDYoJvwieSev4OPb2qHIG2wltsMpeBvdqCyBRPqUjgq0XUviydpeeTQ=  ;
From: David Brownell <david-b@pacbell.net>
To: "Uwe =?iso-8859-1?q?Kleine-K=F6nig?=" 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] move mmci-omap-hs's probe function to .devinit.text
Date: Sat, 11 Jul 2009 15:29:20 -0700
User-Agent: KMail/1.9.10
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       Jean Pihet <jpihet@mvista.com>, Tony Lindgren <tony@atomide.com>,
       Pierre Ossman <drzeus@drzeus.cx>, Andy Lowe <alowe@mvista.com>,
       Adrian Hunter <ext-adrian.hunter@nokia.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Madhusudhan Chikkature <madhu.cr@ti.com>
References: <20090711170548.GC5205@suse.de> <1247345591-22643-24-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-25-git-send-email-u.kleine-koenig@pengutronix.de>
In-Reply-To: <1247345591-22643-25-git-send-email-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200907111529.21165.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 711
Lines: 17

On Saturday 11 July 2009, Uwe Kleine-K?nig wrote:
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.

And that's the preferred fix ... NAK on this one.

In fact its quite rare for any SoC device to be hotpluggable,
so your default stance in such cases should be to switch over
to platform_driver_probe() instead of doing like this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/