Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbZGLAhM (ORCPT ); Sat, 11 Jul 2009 20:37:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751826AbZGLAhB (ORCPT ); Sat, 11 Jul 2009 20:37:01 -0400 Received: from eddie.linux-mips.org ([78.24.191.182]:56452 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbZGLAhA (ORCPT ); Sat, 11 Jul 2009 20:37:00 -0400 Date: Sun, 12 Jul 2009 01:36:56 +0100 (BST) From: "Maciej W. Rozycki" To: =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= cc: Greg KH , linux-kernel@vger.kernel.org, Weiwei Wang , Jeff Garzik , "David S. Miller" , Stephen Hemminger , Andrew Morton Subject: Re: [PATCH] move sb1250-mac's probe function to .devinit.text In-Reply-To: <1247345591-22643-30-git-send-email-u.kleine-koenig@pengutronix.de> Message-ID: References: <20090711170548.GC5205@suse.de> <1247345591-22643-18-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-19-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-20-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-21-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-22-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-23-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-24-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-25-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-26-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-27-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-28-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-29-git-send-email-u.kleine-koenig@pengutronix.de> <1247345591-22643-30-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 33 On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote: > A pointer to sbmac_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-K?nig > Cc: Weiwei Wang > Cc: Jeff Garzik > Cc: David S. Miller > Cc: Stephen Hemminger > Cc: Maciej W. Rozycki > Cc: Andrew Morton > --- > drivers/net/sb1250-mac.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Maciej W. Rozycki Fine by me, thanks. Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/