DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=fziKxwZAew5oxA+l5BfWo02FwRTwW5WUInEUZJ8epP+PBZs/LJhO5K8s8MwiEsVplvMEvJ7qd1k5L226uOlxYRHHI2A+bDXWcAAfJQRIC0JwNmjKSwV7+rTuedTNK7nuzKy6kDsbx4eDaXHSDeqWqHT4qZ9VZXqmStcoCfjl5lM=  ;
From: David Brownell <david-b@pacbell.net>
To: "Uwe =?iso-8859-1?q?Kleine-K=F6nig?=" 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] move omap_udc's probe function to .devinit.text
Date: Sun, 12 Jul 2009 02:37:51 -0700
User-Agent: KMail/1.9.10
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       Philipp Zabel <philipp.zabel@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Tony Lindgren <tony@atomide.com>, Russell King <rmk@arm.linux.org.uk>,
       Dmitry Baryshkov <dbaryshkov@gmail.com>
References: <20090711170548.GC5205@suse.de> <200907111530.44736.david-b@pacbell.net> <20090712083510.GA24424@pengutronix.de>
In-Reply-To: <20090712083510.GA24424@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200907120237.51595.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1431
Lines: 40

On Sunday 12 July 2009, Uwe Kleine-K?nig wrote:
> 
> > Repeat -- NAK on this. ?Use platform_driver_probe() instead.
> > 
> > I really don't like this series of patches. ?It's just adding
> > bloat to kernels, in chunks of up to a page per patch.
>
> I'm aware that in some cases platform_driver_probe is better.

Make that "most cases".  It's rare that platform devices get
hotplugged.  Mostly they're set up at system init ... often
it's all done by the time arch_initcall() finishes.


> But as I 
> don't have access to most of the affected platforms I consider it saver.
> That's why I choosed this way.

You do have access to the source tree, and a powerful little
tool called "grep -r" ... which can easily tell you where the
devices for those platforms are defined.  And thus let you see
if a given one happens to be one of the exceptional cases where
platform_driver_probe() won't work.


> The problem with platform_driver_probe 
> is that if a device is added only after the driver is probed the
> device isn't bound.

That's rarely a problem though; it certainly isn't in the case of
the $SUBJECT driver, and others on that platform.  I've pointed
that out to you before.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/