Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbZGLNYi (ORCPT ); Sun, 12 Jul 2009 09:24:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752174AbZGLNYa (ORCPT ); Sun, 12 Jul 2009 09:24:30 -0400 Received: from casper.infradead.org ([85.118.1.10]:43673 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752123AbZGLNYa (ORCPT ); Sun, 12 Jul 2009 09:24:30 -0400 Subject: Re: [PATCH][RFC] Adding information of counts processes acquired how many spinlocks to schedstat From: Peter Zijlstra To: Hitoshi Mitake Cc: andi@firstfloor.org, fweisbec@gmail.com, mingo@elte.hu, acme@redhat.com, linux-kernel@vger.kernel.org In-Reply-To: <20090712.162337.287595819039280884.mitake@dcl.info.waseda.ac.jp> References: <20090706115451.GA29715@one.firstfloor.org> <20090710.214547.34380852.mitake@dcl.info.waseda.ac.jp> <1247230336.7529.34.camel@twins> <20090712.162337.287595819039280884.mitake@dcl.info.waseda.ac.jp> Content-Type: text/plain Date: Sun, 12 Jul 2009 15:24:05 +0200 Message-Id: <1247405045.6733.2.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1838 Lines: 45 On Sun, 2009-07-12 at 16:23 +0900, Hitoshi Mitake wrote: > Thanks, I understood your advice. Using infrastructure of ftrace is good idea, so I'll use it. > > But I have a question. > I can't enable CONFIG_EVENT_PROFILE because it depends on CONFIG_EVENT_TRACER. > And CONFIG_EVENT_TRACER seems something never enabled. > > % git grep EVENT_TRACER > arch/arm/configs/cm_x300_defconfig:# CONFIG_EVENT_TRACER is not set > arch/arm/configs/davinci_all_defconfig:# CONFIG_EVENT_TRACER is not set > arch/arm/configs/ep93xx_defconfig:# CONFIG_EVENT_TRACER is not set > .... > arch/x86/configs/i386_defconfig:# CONFIG_EVENT_TRACER is not set > arch/x86/configs/x86_64_defconfig:# CONFIG_EVENT_TRACER is not set > init/Kconfig: depends on PERF_COUNTERS && EVENT_TRACER > > In addition, this is the output of searching this on menuconfig > Symbol: EVENT_TRACER [=EVENT_TRACER] > and, there is a log in git > > commit a7abe97fd8e7a6ccabba5a04a9f17be9211d418c > Author: Steven Rostedt > Date: Mon Apr 20 10:59:34 2009 -0400 > > tracing: rename EVENT_TRACER config to ENABLE_EVENT_TRACING > > Currently we have two configs: EVENT_TRACING and EVENT_TRACER. > All tracers enable EVENT_TRACING. The EVENT_TRACER is only a > convenience to enable the EVENT_TRACING when no other tracers > are enabled. > > Does EVENT_TRACER make any sense? > If doesn't, can I remove dependency of CONFIG_EVENT_PROFILE? Yeah, steve broke it, but then Jason fixed it again, but his patches might not have made it in yet. http://lkml.org/lkml/2009/7/6/313 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/