Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 11 Mar 2002 17:46:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 11 Mar 2002 17:46:17 -0500 Received: from mail.pha.ha-vel.cz ([195.39.72.3]:61191 "HELO mail.pha.ha-vel.cz") by vger.kernel.org with SMTP id ; Mon, 11 Mar 2002 17:45:57 -0500 Date: Mon, 11 Mar 2002 23:45:53 +0100 From: Vojtech Pavlik To: Linus Torvalds Cc: Alan Cox , Rik van Riel , Martin Dalecki , Vojtech Pavlik , Martin Dalecki , LKML Subject: Re: [patch] My AMD IDE driver, v2.7 Message-ID: <20020311234553.A3490@ucw.cz> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from torvalds@transmeta.com on Mon, Mar 11, 2002 at 02:39:14PM -0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 11, 2002 at 02:39:14PM -0800, Linus Torvalds wrote: > On Mon, 11 Mar 2002, Alan Cox wrote: > > > > Its quite different to other goings on > > Alan, did you actually look at the diffs that Martin sent out, or are you > just reacting to the description? > > I think you read more into the description than was actually in the patch > itself. > > Rule #1: always read the patch. > > Right now, that patch definitely needs to learn to use "yield()" instead > of "schedule()" etc details, but I really don't understand why all the > brouhaha over Martins patches. > > Am I really the only one who actually reads the actual _changes_ instead > of arguing over personal issues? > > Now, I've long had this theory that IDE coding is bad for your mental > health (you won't ever see _me_ going close to the dang thing - I'll use > it, but I won't start writing code for it), but that theory used to be a > _joke_, for chrissake! Don't make it appear a truism. Are you, by any chance, confusing my AMD IDE changes with Pavel Machek's first attempt at IDE wake/suspend code? Gee, I think we all need some calming down and sleep ... -- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/