DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=LCgNZs6sy88iTMy+8S0y9aRC9GYx0fNggpf3lufWZq1SiKoK52CeUNU0QvAyrjNT0i5y5g4b/rhurTke2JMHReKuhKuMzXT+LgZBWKFEHBs1UsU73/GU585NDuUpeVbsNGJgnsAp/TzJVH2KJkN2p30wschl9u5KKkDlKC2efHM=  ;
From: David Brownell <david-b@pacbell.net>
To: "Uwe =?iso-8859-1?q?Kleine-K=F6nig?=" 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] move omap_udc's probe function to .devinit.text
Date: Sun, 12 Jul 2009 15:12:18 -0700
User-Agent: KMail/1.9.10
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       Philipp Zabel <philipp.zabel@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Tony Lindgren <tony@atomide.com>, Russell King <rmk@arm.linux.org.uk>,
       Dmitry Baryshkov <dbaryshkov@gmail.com>
References: <20090711170548.GC5205@suse.de> <200907111530.44736.david-b@pacbell.net> <20090712204803.GA27454@pengutronix.de>
In-Reply-To: <20090712204803.GA27454@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200907121512.18358.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1879
Lines: 67

On Sunday 12 July 2009, Uwe Kleine-K?nig wrote:
> On Sat, Jul 11, 2009 at 03:30:44PM -0700, David Brownell wrote:
> > Repeat -- NAK on this.  Use platform_driver_probe() instead.
>
> Oh, I just noticed that this patch is a relict.  The driver was changed
> to use platform_driver_probe in
> 864e28b4f24106b799e991fa136fa6fa2b638a68.

Good.
 

> And I just found another similar problem.
> E.g. clevo_mail_led_probe is defined to live in .init.text and uses
> platform_driver_probe, but as it's referenced in the driver struct my
> script matched this file.
> 
> (Is it wrong (wrong as in "worth to be fixed") to reference the probe
> function in the driver struct when platform_driver_probe is used?

Wrong, but not dangerous ... so fix, but at low priority.
At least, low until the DEBUG_SECTION_MISMATCH stuff gets
re-enabled.

When platform_driver_probe() returns, that driver field willl
have changed to something safe.


> If so 
> at least
> 
> 	drivers/serial/msm_serial.c
> 	drivers/i2c/busses/i2c-imx.c
> 
> are effected, too.  Patches at
> 
> 	http://news.gmane.org/find-root.php?group=gmane.linux.ports.arm.kernel&article=62319
> 
> )
> 
> The other patches are not affected.
> 
> @Greg:  Please just drop these two patches:
> 
> 	[PATCH] move omap_udc's probe function to .devinit.text
> 	[PATCH] move leds-clevo-mail's probe function to .devinit.text

... and the others I NAKed too.


> 
> Sorry for the unconvenience.
> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                              | Uwe Kleine-K?nig            |
> Industrial Linux Solutions                    | http://www.pengutronix.de/  |
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/