DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=g7G9D8ssPtq/J/XHfAfBWoI/GiC66wCo89uwTumS9nQZBbW0UCRlWAdWkKlgwzTuGbLuXdXC9/i6rYO3/oUUtnm7PrBeRTMR1MxaYIM8zZR2PfUd/NXcfOs/i/JBH5lKgrF0gArigoRkirROp5SZQOmHcaIlA/o/nnymbcpEa7w=  ;
From: David Brownell <david-b@pacbell.net>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [PATCH] move omap_udc's probe function to .devinit.text
Date: Sun, 12 Jul 2009 15:21:30 -0700
User-Agent: KMail/1.9.10
Cc: "Uwe =?iso-8859-1?q?Kleine-K=F6nig?=" 
	<u.kleine-koenig@pengutronix.de>,
       Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       Philipp Zabel <philipp.zabel@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Tony Lindgren <tony@atomide.com>,
       Dmitry Baryshkov <dbaryshkov@gmail.com>
References: <20090711170548.GC5205@suse.de> <20090712084734.GA944@flint.arm.linux.org.uk> <20090712131732.GA4406@flint.arm.linux.org.uk>
In-Reply-To: <20090712131732.GA4406@flint.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200907121521.31188.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1172
Lines: 28

On Sunday 12 July 2009, Russell King wrote:
> 	?David's approach is an enhancement whereas your patches
> are a bug fix.

Not an enhancement.  Uwe's current approach causes regressions
in terms of kernel runtime footprint.  That is, pages will newly
be made to sit around doing *nothing* forever, when they could
have been used to get Real Work done.  And, pre-patches, they
would have been getting Real Work done.

If it weren't a regression I wouldn't have objected.

A few years back, I measured the impact of having probe() and
friends in a section -- init{,data} vs devinit{,data} -- that gets
removed.  Most drivers were in the 1K-2K range.  $SUBJECT was
larger than most, but there were some with even more discardable
init logic.

All that adds up.  There's no point to commiting patches that
do things wrong *and* waste space, then need to fix things up
again later when it's easy to do it right in the first place.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/