Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754377AbZGMHiG (ORCPT ); Mon, 13 Jul 2009 03:38:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752773AbZGMHiD (ORCPT ); Mon, 13 Jul 2009 03:38:03 -0400 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:64341 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbZGMHiC (ORCPT ); Mon, 13 Jul 2009 03:38:02 -0400 Message-ID: <4A5AB903.6090204@mxs.nes.nec.co.jp> Date: Mon, 13 Jul 2009 13:33:07 +0900 From: "Ken'ichi Ohmichi" User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Hidetoshi Seto CC: kexec-ml , lkml Subject: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded. References: <4A55A4AE.3000206@mxs.nes.nec.co.jp> <4A56E069.5040907@jp.fujitsu.com> In-Reply-To: <4A56E069.5040907@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1476 Lines: 48 Hi, This patch is a new version by Seto-san's comment. Changelog since v1: * Remove the check code other than kexec_crash_image from kexec_should_crash() because a kexec cannot crash if there is no image. This patch enables a kdump if 2nd-kernel is loaded. (The patch is based on linux-2.6.31-rc2.) Now, a kdump on oops is enabled if a kernel parameter "oops=panic" is specified and 2nd-kernel is loaded. I think that a kdump should be enabled regardless of "oops=panic" if 2nd-kernel is loaded, because a system administrator loads 2nd-kernel for enabling a kdump. * Reference The discussion about this patch http://lists.infradead.org/pipermail/kexec/2009-July/003417.html http://lists.infradead.org/pipermail/kexec/2009-July/003433.html Thanks Ken'ichi Ohmichi Signed-off-by: Ken'ichi Ohmichi Acked-by: Simon Horman --- --- a/kernel/kexec.c 2009-07-08 12:30:26.000000000 +0900 +++ b/kernel/kexec.c 2009-07-13 13:49:03.000000000 +0900 @@ -57,7 +57,7 @@ struct resource crashk_res = { int kexec_should_crash(struct task_struct *p) { - if (in_interrupt() || !p->pid || is_global_init(p) || panic_on_oops) + if (kexec_crash_image) return 1; return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/