Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754806AbZGMIoz (ORCPT ); Mon, 13 Jul 2009 04:44:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754664AbZGMIoz (ORCPT ); Mon, 13 Jul 2009 04:44:55 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:28955 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754340AbZGMIoy convert rfc822-to-8bit (ORCPT ); Mon, 13 Jul 2009 04:44:54 -0400 Message-Id: <4A5B101E020000780000A284@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.0 Date: Mon, 13 Jul 2009 09:44:46 +0100 From: "Jan Beulich" To: "Michal Marek" Cc: "Ingo Molnar" , , "Jon Masters" , "Thomas Gleixner" , "Rusty Russell" , , , , Subject: Re: [PATCH] reduce export symbol CRC table size on 64-bit archs References: <4A4A18780200007800008345@vpn.id2.novell.com> <4A4E671C.2090201@suse.cz> <4A51C71B0200007800008EE2@vpn.id2.novell.com> <200907092044.22108.rusty@rustcorp.com.au> <4A57089B0200007800009C0E@vpn.id2.novell.com> <4A5AEC3C.2060608@suse.cz> In-Reply-To: <4A5AEC3C.2060608@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 22 >>> Michal Marek 13.07.09 10:11 >>> >Jan Beulich napsal(a): >> Actually I meanwhile think that module-init-tools can easily detect the changed >> layout without any further kernel side adjustments: Since it is known that a >> CRC always is a 32-bit value, simply checking whether the so-far-used 64-bit >> value has more than 32 significant bits should suffice: If so, the new layout >> is being used (with the symbol name starting at offset 4), else the old one is >> in effect (name at offset 8). This ought to be a pretty trivial change to that >> code. > >But old module-init-tools will continue reading garbage in this case. And would you think returning nothing is significantly better than returning garbage? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/