Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754833AbZGMIwN (ORCPT ); Mon, 13 Jul 2009 04:52:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754731AbZGMIwM (ORCPT ); Mon, 13 Jul 2009 04:52:12 -0400 Received: from mail-qy0-f192.google.com ([209.85.221.192]:46412 "EHLO mail-qy0-f192.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754706AbZGMIwL (ORCPT ); Mon, 13 Jul 2009 04:52:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=j9ZA8dKHb1j/DPgYasTfIEApEll92IYg5EDGhH+Is/hS29uTPx1J64G7+6jiJtxYdb BWKXWfAuLCtwENGJFpTJqzwRt7FSdBd0PLqCQapWSaG/y7CkseMdq7QOJQKsrWxzfMNu 39gPffY5C/Bc0MDl5Ht5vyv5SLR8pmiUDUPRw= MIME-Version: 1.0 In-Reply-To: <5d5443650906191038o797e0c3eu8234a56ee247ea68@mail.gmail.com> References: <4A04E5EA.7000103@samsung.com> <5d5443650905091027w2b60f2ael520373790e6414c7@mail.gmail.com> <4d34a0a70905101934j320c03abl7e39af4fbfdf1f62@mail.gmail.com> <20090511031208.GA15208@dtor-d630.eng.vmware.com> <5d5443650906191038o797e0c3eu8234a56ee247ea68@mail.gmail.com> Date: Mon, 13 Jul 2009 14:22:10 +0530 Message-ID: <5d5443650907130152t420e9426q762c24bdb1b29aae@mail.gmail.com> Subject: Re: [PATCH] Input: add MAX7359 key switch controller driver, v2 From: Trilok Soni To: Dmitry Torokhov Cc: Kim Kyuwon , Kim Kyuwon , LKML , linux-input@vger.kernel.org, Kyungmin Park , Marek Szyprowski Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 53 Hi Dmitry, On Fri, Jun 19, 2009 at 11:08 PM, Trilok Soni wrote: > Hi, > > On Mon, May 11, 2009 at 8:42 AM, Dmitry > Torokhov wrote: >> On Mon, May 11, 2009 at 11:34:54AM +0900, Kim Kyuwon wrote: >>> Hi Trilok, >>> >>> On Sun, May 10, 2009 at 2:27 AM, Trilok Soni wrote: >>> > Hi Kim, >>> > >>> > On Sat, May 9, 2009 at 7:39 AM, Kim Kyuwon wrote: >>> >> The Maxim MAX7359 is a I2C interfaced key switch controller which provides >>> >> microprocessors with management of up to 64 key switches. >>> >> This patch adds support for the MAX7359 key switch controller. >>> >> >>> >> Signed-off-by: Kim Kyuwon >>> > >>> > >>> > Thanks for implementing review comments. Please add >>> > >>> > Reviewed-by: Trilok Soni >>> >>> Sorry, I didn't know I should put the "Reviewed-by" in the reviewed >>> patch.(I'm still kernelnewbie :) ) >> >> You are not supposed to add it until somebody explicitely asks you to >> do that, same with Acked-by... The reason is that these tags constitute >> certain endorsement of the patch and while one person may review the >> patch he/she may not yet feel that review process is complete. Hope this >> makes some sense... >> >>> If possible, I want Dmitry to add >>> "Reviewed-by" when he sends this driver to mainline, or I will send >>> new patch again. >>> >> >> I have it added to my copy. I don't see this driver picked up yet in your -next branch. We should target this driver to be mainlined in next merge window. This is very important driver for some of the embedded systems, including palm pre :) http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/