Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755793AbZGMM7j (ORCPT ); Mon, 13 Jul 2009 08:59:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755574AbZGMM7j (ORCPT ); Mon, 13 Jul 2009 08:59:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53769 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755542AbZGMM7i (ORCPT ); Mon, 13 Jul 2009 08:59:38 -0400 From: Nikanth Karthikesan Organization: suse.de To: balbir@linux.vnet.ibm.com Subject: [RFC][PATCH] taskstats: Fix CGROUPSTATS_TYPE_CGROUP_STATS having same value as TASKSTATS_TYPE_PID Date: Mon, 13 Jul 2009 18:31:12 +0530 User-Agent: KMail/1.11.1 (Linux/2.6.27.23-0.1-default; KDE/4.2.1; x86_64; ; ) Cc: Paul Menage , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907131831.12994.knikanth@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1819 Lines: 52 Hi Currently we never get message from kernel to userspace of type TASKSTATS_TYPE_PID. Otherwise this could have been spotted earlier. I was trying to add a new taskstat command that would return response of type TASKSTATS_TYPE_PID. Having the same values would restrict one not to use the same netlink socket for a command that would return response of type TASKSTATS_TYPE_PID and the CGROUPSTATS_CMD_GET command. Should we fix it by using values after __TASKSTATS_TYPE_MAX. Changing this now might break pre-built binaries. Or is this intended, and the application is not supposed to use CGROUPSTATS and TASKSTATS on the same socket? Thanks Nikanth Currently we never get message from kernel to userspace of type TASKSTATS_TYPE_PID. Otherwise this could have been spotted earlier. Having the values in the same range would restrict one not to use the same netlink socket for a command that would return response of type TASKSTATS_TYPE_PID and the CGROUPSTATS_CMD_GET command. Fix it by using values after __TASKSTATS_TYPE_MAX. Signed-off-by: Nikanth Karthikesan --- diff --git a/include/linux/cgroupstats.h b/include/linux/cgroupstats.h index 3753c33..87b31f0 100644 --- a/include/linux/cgroupstats.h +++ b/include/linux/cgroupstats.h @@ -53,7 +53,7 @@ enum { #define CGROUPSTATS_CMD_MAX (__CGROUPSTATS_CMD_MAX - 1) enum { - CGROUPSTATS_TYPE_UNSPEC = 0, /* Reserved */ + CGROUPSTATS_TYPE_UNSPEC = __TASKSTATS_TYPE_MAX, /* Reserved */ CGROUPSTATS_TYPE_CGROUP_STATS, /* contains name + stats */ __CGROUPSTATS_TYPE_MAX, }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/