Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755921AbZGMNnX (ORCPT ); Mon, 13 Jul 2009 09:43:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755840AbZGMNnX (ORCPT ); Mon, 13 Jul 2009 09:43:23 -0400 Received: from mx2.redhat.com ([66.187.237.31]:50026 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755829AbZGMNnW (ORCPT ); Mon, 13 Jul 2009 09:43:22 -0400 Subject: Re: inotify regression, missing events From: Eric Paris To: Scott James Remnant Cc: linux-kernel@vger.kernel.org In-Reply-To: <1247487669.14981.18.camel@quest> References: <1247328127.4003.6.camel@wing-commander> <1247313019.2791.1.camel@localhost> <1247487669.14981.18.camel@quest> Content-Type: text/plain Date: Mon, 13 Jul 2009 09:43:19 -0400 Message-Id: <1247492599.3068.19.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 30 On Mon, 2009-07-13 at 13:21 +0100, Scott James Remnant wrote: > On Sat, 2009-07-11 at 07:50 -0400, Eric Paris wrote: > > > On Sat, 2009-07-11 at 17:02 +0100, Scott James Remnant wrote: > > > Looks like there's a regression with inotify since the rewrite to use > > > fanotify. Events are simply missing and not being delivered to > > > userspace. > > > > > > Here's a simple test case, just compile and run it: > > > > I bet I know exactly what it is (notification.c tail merge code isn't > > comparing filename only inode+mask) but I'm walking out of the house. > > I'll try my theory later tonight and post a patch. > > > > Stupid Eric, Stupid. > > > In other words, when the second deleted-file-in-a-directory event comes > through, it gets ignored because there's already a > "deleted-file-in-a-directory" event for that directory? Yes, and I sent a patch but apparent screwed up the --smtp-server option so it never got out. Resending. Sorry..... -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/