Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbZGOGVs (ORCPT ); Wed, 15 Jul 2009 02:21:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752187AbZGOGVr (ORCPT ); Wed, 15 Jul 2009 02:21:47 -0400 Received: from mail-qy0-f192.google.com ([209.85.221.192]:42076 "EHLO mail-qy0-f192.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbZGOGVq convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2009 02:21:46 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=SOpxUFS/shxdw8OH5zO7QPIBczhQp1Whqe3ZuffDQwfkfdIEAU8Gxcah1i5JTAY3Tf 5rb/2n3PGGI2ok0sHCFfm3LNLFtRt98dm4ydbh1s8EcugYtrA5qGBi8KG9+mzNqyJx0q PA71ZcqRQuuVaen1QwQfclgNf7auUA6BPncUc= MIME-Version: 1.0 In-Reply-To: References: <20090710084323.GA6522@elf.ucw.cz> <20090713202302.GC2569@elf.ucw.cz> <20090713205749.GE2569@elf.ucw.cz> <20090713220726.GA28375@elf.ucw.cz> <20090714094629.GB2076@elf.ucw.cz> <20090714221638.GA6512@elf.ucw.cz> Date: Wed, 15 Jul 2009 11:51:44 +0530 Message-ID: <5d5443650907142321r1a4381eel96b955d85cd87114@mail.gmail.com> Subject: Re: HTC: touchscreen driver From: Trilok Soni To: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Cc: Pavel Machek , Brian Swetland , kernel list , linux-input@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2063 Lines: 51 Hi Arve, 2009/7/15 Arve Hj?nnev?g : > On Tue, Jul 14, 2009 at 3:16 PM, Pavel Machek wrote: > ... >>> >> This driver only supports a subset of Synaptics' devices so a more >>> >> generic driver will eventually be needed. The patch below adds support >>> >> for a more recent but similar panel. >>> > >>> > Ok, that should be simple enough to apply, but lets do improvements >>> > when we cleaned the code enough for the mainline...? >>> >>> We need this change now. Your cleanup will cause conflicts for anyone >>> using our driver, so it would be better if it includes all our fixes. >> >> Well, I don't expect you to use the cleaned-up driver as-is: I had to >> remove the wakelocks functionality as infrastructure is not in >> mainline. > > OK. The driver does not use wakelocks tough, only earlysuspend, so > your cleaned up version should be fully functional. The early suspend > hooks are only used to save power in idle when the screen is off. > >> (Plus, I do not have hardware to test your latest version). > > True, but the protocol documentation is available: > http://www.synaptics.com/sites/default/files/511_000099_01F.pdf > >> >> Applying small patch on top of cleaned up driver should be better than >> carrying whole driver itself, right? > > Perhaps, but the only problem I encountered with this driver so far > was when calling disable_irq from the interrupt handler stopped > working on non-smp systems in 2.6.30 (which is another patch you > should probably apply first). disable_irq review comment is already given in the patch posted on linux-input by Pavel. We should convert this driver to request_threaded_irq infrastructure instead. I have added linux-input ML in CC. -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/