Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753391AbZGOJKd (ORCPT ); Wed, 15 Jul 2009 05:10:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752325AbZGOJKc (ORCPT ); Wed, 15 Jul 2009 05:10:32 -0400 Received: from cantor.suse.de ([195.135.220.2]:48341 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbZGOJKc (ORCPT ); Wed, 15 Jul 2009 05:10:32 -0400 Date: Wed, 15 Jul 2009 11:10:31 +0200 Message-ID: From: Takashi Iwai To: Jaswinder Singh Rajput Cc: LKML Subject: Re: sound/pci/riptide/riptide.c compiler warning In-Reply-To: <1247639250.2437.11.camel@ht.satnam> References: <1247639250.2437.11.camel@ht.satnam> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 38 At Wed, 15 Jul 2009 11:57:30 +0530, Jaswinder Singh Rajput wrote: > > I am getting this compiler warning in linus tree : > > CC [M] sound/pci/riptide/riptide.o > sound/pci/riptide/riptide.c: In function ‘alsa_card_riptide_init’: > sound/pci/riptide/riptide.c:2200: warning: ignoring return value of ‘__pci_register_driver’, declared with attribute warn_unused_result > > This fixes the warning in my case, hope this will be helpful : > > diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c > index 235a71e..fd8a552 100644 > --- a/sound/pci/riptide/riptide.c > +++ b/sound/pci/riptide/riptide.c > @@ -2197,9 +2197,9 @@ static int __init alsa_card_riptide_init(void) > if (err < 0) > return err; > #if defined(SUPPORT_JOYSTICK) > - pci_register_driver(&joystick_driver); > + err = pci_register_driver(&joystick_driver); > #endif > - return 0; > + return err; In that case, the formerly registered audio driver should be unregistered before returning the error from the probe callback. Could you fix that? thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/