Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404AbZGOJLV (ORCPT ); Wed, 15 Jul 2009 05:11:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752509AbZGOJLV (ORCPT ); Wed, 15 Jul 2009 05:11:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57440 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426AbZGOJLU (ORCPT ); Wed, 15 Jul 2009 05:11:20 -0400 Date: Wed, 15 Jul 2009 11:11:19 +0200 Message-ID: From: Takashi Iwai To: Jaswinder Singh Rajput Cc: Mark Brown , LKML Subject: Re: sound/soc/codecs/wm9081.c compiler warning In-Reply-To: <1247639434.2437.14.camel@ht.satnam> References: <1247639434.2437.14.camel@ht.satnam> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 49 At Wed, 15 Jul 2009 12:00:34 +0530, Jaswinder Singh Rajput wrote: > > I am getting this compiler warning in linus tree: > > CC [M] sound/soc/codecs/wm9081.o > sound/soc/codecs/wm9081.c: In function ‘configure_clock’: > sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function > > This fixes the warning in my case, hope this will be helpful : I think your fix is OK, but I let it to Mark :) thanks, Takashi > > diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c > index 86fc57e..77a7997 100644 > --- a/sound/soc/codecs/wm9081.c > +++ b/sound/soc/codecs/wm9081.c > @@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec) > * not the case, though care must be taken with free > * running mode. > */ > + new_sysclk = 12288000; > if (wm9081->master && wm9081->bclk) { > /* Make sure we can generate CLK_SYS and BCLK > * and that we've got 3MHz for optimal > @@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec) > if (new_sysclk > 3000000) > break; > } > - } else { > - new_sysclk = 12288000; > } > > ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK, > > -- > JSR > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/