Date: Wed, 15 Jul 2009 11:16:06 -0700 (PDT)
Message-Id: <20090715.111606.193724419.davem@davemloft.net>
To: petkovbb@googlemail.com
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ide-tape: misc stuff
From: David Miller <davem@davemloft.net>
In-Reply-To: <1247671100-8173-1-git-send-email-petkovbb@gmail.com>
References: <1247671100-8173-1-git-send-email-petkovbb@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1061
Lines: 33

From: Borislav Petkov <petkovbb@googlemail.com>
Date: Wed, 15 Jul 2009 17:18:16 +0200

> here is some ide-tape stuff.
> 
> * 0001: somehow fell through the cracks, DEBUG build fix

This is OK.

> * 0002: mostly code unification

I'm not applying this.  IDE is in deep maintainence mode and
we really need to avoid changes that don't fix real bugs and
have only marginal benefit, like this change.

> * 0003: this one converts ide-tape to the debugging scheme we use with ide-cd
>   and ide-floppy. It adds some debug calls at important places and has proven
>   very helpful when working on bug reports with users. No functional change.

I'm not applying this for the same reason as patch #2.

> * 0004: real bugfix

Ok, did you test this?

Please respin patch #1 and #4 as a two patch set and resubmit.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/