Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbZGPHm2 (ORCPT ); Thu, 16 Jul 2009 03:42:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752539AbZGPHm2 (ORCPT ); Thu, 16 Jul 2009 03:42:28 -0400 Received: from gg.genua.de ([151.136.100.2]:31439 "EHLO gg.genua.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752486AbZGPHm1 (ORCPT ); Thu, 16 Jul 2009 03:42:27 -0400 From: Sten Spans Date: Thu, 16 Jul 2009 09:41:39 +0200 To: James Morris Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: security_file_lock cmd argument Message-ID: <20090716074139.GB23769@false> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 37 On Thu, Jul 16, 2009 at 10:05:47AM +1000, James Morris wrote: > > From: Sten Spans > > This looks good, but you need to add a signed-off-by line per > Documentation/SubmittingPatches > Makes sense, how about: Pass posix-translated lock operations to security_file_lock when invoked via sys_flock. Signed-off-by: Sten Spans --- fs/locks.c.orig 2009-07-09 11:26:45.000000000 +0200 +++ fs/locks.c 2009-07-09 11:27:24.000000000 +0200 @@ -1590,7 +1590,7 @@ if (can_sleep) lock->fl_flags |= FL_SLEEP; - error = security_file_lock(filp, cmd); + error = security_file_lock(filp, lock->fl_type); if (error) goto out_free; -- GeNUA Gesellschaft f?r Netzwerk - und Unix-Administration mbH Domagkstr. 7, D-85551 Kirchheim. http://www.genua.de Tel: (089) 99 19 50-0, Fax: (089) 99 19 50 - 999 Gesch?ftsf?hrer: Dr. Magnus Harlander, Dr. Michaela Harlander, Bernhard Schneck. Amtsgericht M?nchen HRB 98238 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/